Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Issue 1260183006: Move atlas creation to internal to GrResourceProvider (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@debugatlas
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move atlas creation to internal to GrResourceProvider BUG=skia: Committed: https://skia.googlesource.com/skia/+/b356cbc765468e2594fca9ec6e5476a3da145d26

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment tweaked #

Patch Set 3 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -65 lines) Patch
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 3 chunks +11 lines, -28 lines 0 comments Download
M src/gpu/GrBatchFontCache.cpp View 1 chunk +13 lines, -37 lines 0 comments Download
M src/gpu/GrResourceProvider.h View 1 2 chunks +21 lines, -0 lines 0 comments Download
M src/gpu/GrResourceProvider.cpp View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
joshualitt
ptal
5 years, 4 months ago (2015-08-04 17:10:02 UTC) #2
bsalomon
https://codereview.chromium.org/1260183006/diff/1/src/gpu/GrResourceProvider.h File src/gpu/GrResourceProvider.h (right): https://codereview.chromium.org/1260183006/diff/1/src/gpu/GrResourceProvider.h#newcode118 src/gpu/GrResourceProvider.h:118: /** Returns a GrBatchAtlas. Should only be used inside ...
5 years, 4 months ago (2015-08-04 17:39:41 UTC) #3
joshualitt
On 2015/08/04 17:39:41, bsalomon wrote: > https://codereview.chromium.org/1260183006/diff/1/src/gpu/GrResourceProvider.h > File src/gpu/GrResourceProvider.h (right): > > https://codereview.chromium.org/1260183006/diff/1/src/gpu/GrResourceProvider.h#newcode118 > ...
5 years, 4 months ago (2015-08-04 17:44:54 UTC) #4
bsalomon
On 2015/08/04 17:44:54, joshualitt wrote: > On 2015/08/04 17:39:41, bsalomon wrote: > > https://codereview.chromium.org/1260183006/diff/1/src/gpu/GrResourceProvider.h > ...
5 years, 4 months ago (2015-08-04 18:18:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260183006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260183006/40001
5 years, 4 months ago (2015-08-04 21:18:33 UTC) #10
commit-bot: I haz the power
Failed to commit the patch.
5 years, 4 months ago (2015-08-04 21:29:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260183006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260183006/40001
5 years, 4 months ago (2015-08-05 13:36:07 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 13:36:42 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b356cbc765468e2594fca9ec6e5476a3da145d26

Powered by Google App Engine
This is Rietveld 408576698