Android: improve native debuggability

When starting with --wait-for-debugger command line option, it's ending
up in a busy loop waiting for a variable to be changed. Change that busy
loop from a macro to a function. It avoids having to step on instruction
level to find the right stack frame before the variable is visible.

[darin (slow to review), 2013-03-19 22:24:14]

It feels like the GYPI change is addressing an independent issue.  It should
probably be broken out into a separate CL.  I'd like someone more familiar with
our Android port to review it.

https://codereview.chromium.org/12717018/diff/1/base/debug/debugger_posix.cc
File base/debug/debugger_posix.cc (right):

https://codereview.chromium.org/12717018/diff/1/base/debug/debugger_posix.cc#...
base/debug/debugger_posix.cc:221: void DEBUG_BREAK() {
nit: I recommend preserving the DEBUG_BREAK macro (in an effort to reduce
surprises between ports), and instead introduce a function that DEBUG_BREAK
resolves to.

void DebugBreak() {
  ...
}
#define DEBUG_BREAK() DebugBreak()

[mostynb%opera.com, 2013-03-20 04:45:36]

On 2013/03/19 22:24:14, darin wrote:
> It feels like the GYPI change is addressing an independent issue.  It should
> probably be broken out into a separate CL.  I'd like someone more familiar
with
> our Android port to review it.

Moved to this CL:
https://codereview.chromium.org/12789009

[mostynb%opera.com, 2013-03-20 05:32:39]

https://codereview.chromium.org/12717018/diff/1/base/debug/debugger_posix.cc
File base/debug/debugger_posix.cc (right):

https://codereview.chromium.org/12717018/diff/1/base/debug/debugger_posix.cc#...
base/debug/debugger_posix.cc:221: void DEBUG_BREAK() {
On 2013/03/19 22:24:14, darin wrote:
> nit: I recommend preserving the DEBUG_BREAK macro (in an effort to reduce
> surprises between ports), and instead introduce a function that DEBUG_BREAK
> resolves to.
> 
> void DebugBreak() {
>   ...
> }
> #define DEBUG_BREAK() DebugBreak()

Done.

[darin (slow to review), 2013-03-20 06:24:33]

https://codereview.chromium.org/12717018/diff/4003/base/debug/debugger_posix.cc
File base/debug/debugger_posix.cc (right):

https://codereview.chromium.org/12717018/diff/4003/base/debug/debugger_posix....
base/debug/debugger_posix.cc:221: void DebugBreak() {
nit: oh, this should probably have static linkage since it is not intended to be
called from outside of this .cc file.

[bulach, 2013-03-20 11:45:06]

nit: the patch title could be prefixed with "Android", like:

"Android: improve native debuggability"

other than that, I'm happy when darin and the bots are happy :)

going forward, feel free to send patches for android my way, I'll be glad to
help / redirect as needed! thanks!

[mostynb%opera.com, 2013-04-08 12:16:21]

Resubmitted with my new/official account (and nit fixed):
https://codereview.chromium.org/13597005