Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 12789009: Android: fix link error for android_full_debug=1 (Closed)

Created:
7 years, 9 months ago by mostynb%opera.com
Modified:
7 years, 8 months ago
Reviewers:
bulach, digit1
CC:
chromium-reviews, Daniel Bratell, lbolstad_opera.com, peterp
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Android: fix link error for android_full_debug=1 Currently android_full_debug=1 fails to link with: "undefined reference to __cxa_bad_typeid". Work around this by telling the linker to ignore unused input sections.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M build/common.gypi View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
bulach
+digit, our compiler expert nit: the patch title should normally be a sentence, and if ...
7 years, 9 months ago (2013-03-20 11:49:30 UTC) #1
digit1
lgtm. For the record, the main issue has been fixed in the AOSP ndk sources, ...
7 years, 9 months ago (2013-03-20 13:57:51 UTC) #2
mostynb%opera.com
On 2013/03/20 13:57:51, digit1 wrote: > *Please* change the description appropriately before submitting this (use ...
7 years, 9 months ago (2013-03-21 00:05:56 UTC) #3
mostynb%opera.com
7 years, 8 months ago (2013-04-08 11:49:45 UTC) #4
Resubmitted here (due to account changes):
https://codereview.chromium.org/13772007/

Powered by Google App Engine
This is Rietveld 408576698