Issue 1271163003: Revert of Break LCD and Bitmap text dependency on hardcoded atlas values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1271163003: Revert of Break LCD and Bitmap text dependency on hardcoded atlas values (Closed)

Created:
5 years, 4 months ago by joshualitt

Modified:
5 years, 4 months ago

Reviewers:
jvanverth1, bsalomon, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Break LCD and Bitmap text dependency on hardcoded atlas values (patchset #2 id:20001 of https://codereview.chromium.org/1271873002/ ) Reason for revert: Breaks S3 Original issue's description: > Break LCD and Bitmap text dependency on hardcoded atlas values > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/846b022f6b469cfde285372f26e0d5c593d122ac TBR=jvanverth@google.com,bsalomon@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/9162ea9444ac3127c3a93a880dc77efc839391b3

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -65 lines)			Patch
M	include/core/SkFloatingPoint.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	src/gpu/GrFontAtlasSizes.h	View	2 chunks	+18 lines, -0 lines	0 comments	Download
M	src/gpu/effects/GrBitmapTextGeoProc.cpp	View	2 chunks	+10 lines, -18 lines	0 comments	Download
M	src/gpu/effects/GrDistanceFieldGeoProc.cpp	View	5 chunks	+8 lines, -38 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

joshualitt

Created Revert of Break LCD and Bitmap text dependency on hardcoded atlas values

5 years, 4 months ago (2015-08-05 13:45:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271163003/1

5 years, 4 months ago (2015-08-05 13:46:06 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-08-05 13:46:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9162ea9444ac3127c3a93a880dc77efc839391b3

Expand Messages | Collapse Messages