Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Unified Diff: Source/core/html/HTMLTextAreaElement.idl

Issue 1269263003: The start and end arguments should be unsigned long in setSelectionRange() function Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLInputElement.idl ('k') | Source/core/html/HTMLTextFormControlElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLTextAreaElement.idl
diff --git a/Source/core/html/HTMLTextAreaElement.idl b/Source/core/html/HTMLTextAreaElement.idl
index ea7ca760f41738b09f32065c1b6f22482c9260d9..0ad6f19a1cc5af95d85a4bd6dc78de53d2f2afc9 100644
--- a/Source/core/html/HTMLTextAreaElement.idl
+++ b/Source/core/html/HTMLTextAreaElement.idl
@@ -53,19 +53,16 @@ interface HTMLTextAreaElement : HTMLElement {
readonly attribute NodeList labels;
void select();
- // TODO(philipj): selectionStart and selectionEnd should be unsigned long.
- attribute long selectionStart;
- attribute long selectionEnd;
+ attribute unsigned long selectionStart;
+ attribute unsigned long selectionEnd;
attribute DOMString selectionDirection;
[RaisesException] void setRangeText(DOMString replacement);
[RaisesException] void setRangeText(DOMString replacement,
unsigned long start,
unsigned long end,
optional SelectionMode selectionMode = "preserve");
- // TODO(philipj): The start and end arguments should be unsigned long and
- // should not be optional.
- void setSelectionRange([Default=Undefined] optional long start,
- [Default=Undefined] optional long end,
+ void setSelectionRange(unsigned long start,
+ unsigned long end,
optional DOMString direction);
// HTML autocapitalize proposal
« no previous file with comments | « Source/core/html/HTMLInputElement.idl ('k') | Source/core/html/HTMLTextFormControlElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698