Source/core/html/HTMLTextAreaElement.idl - Issue 1269263003: The start and end arguments should be unsigned long in setSelectionRange() function

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/HTMLTextAreaElement.idl

Issue 1269263003: The start and end arguments should be unsigned long in setSelectionRange() function Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2010 Apple Inc. All rights reserved.	2 * Copyright (C) 2006, 2010 Apple Inc. All rights reserved.

3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>	3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>

4 * Copyright (C) 2011 Motorola Mobility, Inc. All rights reserved.	4 * Copyright (C) 2011 Motorola Mobility, Inc. All rights reserved.

5 *	5 *

6 * This library is free software; you can redistribute it and/or	6 * This library is free software; you can redistribute it and/or

7 * modify it under the terms of the GNU Library General Public	7 * modify it under the terms of the GNU Library General Public

8 * License as published by the Free Software Foundation; either	8 * License as published by the Free Software Foundation; either

9 * version 2 of the License, or (at your option) any later version.	9 * version 2 of the License, or (at your option) any later version.

10 *	10 *

(...skipping 35 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
46 readonly attribute boolean willValidate;	46 readonly attribute boolean willValidate;

47 readonly attribute ValidityState validity;	47 readonly attribute ValidityState validity;

48 readonly attribute DOMString validationMessage;	48 readonly attribute DOMString validationMessage;

49 boolean checkValidity();	49 boolean checkValidity();

50 boolean reportValidity();	50 boolean reportValidity();

51 void setCustomValidity(DOMString error);	51 void setCustomValidity(DOMString error);

52	52

53 readonly attribute NodeList labels;	53 readonly attribute NodeList labels;

54	54

55 void select();	55 void select();

56 // TODO(philipj): selectionStart and selectionEnd should be unsigned long.	56 attribute unsigned long selectionStart;

57 attribute long selectionStart;	57 attribute unsigned long selectionEnd;

58 attribute long selectionEnd;

59 attribute DOMString selectionDirection;	58 attribute DOMString selectionDirection;

60 [RaisesException] void setRangeText(DOMString replacement);	59 [RaisesException] void setRangeText(DOMString replacement);

61 [RaisesException] void setRangeText(DOMString replacement,	60 [RaisesException] void setRangeText(DOMString replacement,

62 unsigned long start,	61 unsigned long start,

63 unsigned long end,	62 unsigned long end,

64 optional SelectionMode selectionMode = " preserve");	63 optional SelectionMode selectionMode = " preserve");

65 // TODO(philipj): The start and end arguments should be unsigned long and	64 void setSelectionRange(unsigned long start,

66 // should not be optional.	65 unsigned long end,

67 void setSelectionRange([Default=Undefined] optional long start,

68 [Default=Undefined] optional long end,

69 optional DOMString direction);	66 optional DOMString direction);

70	67

71 // HTML autocapitalize proposal	68 // HTML autocapitalize proposal

72 // https://github.com/mounirlamouri/html-autocapitalize/blob/master/proposal .md	69 // https://github.com/mounirlamouri/html-autocapitalize/blob/master/proposal .md

73 [Measure] attribute DOMString autocapitalize;	70 [Measure] attribute DOMString autocapitalize;

74 };	71 };

OLD	NEW

« no previous file with comments | « Source/core/html/HTMLInputElement.idl ('k') | Source/core/html/HTMLTextFormControlElement.h » ('j') | no next file with comments »