Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: mojo/devtools/common/devtoolslib/linux_shell.py

Issue 1268713005: Unify method name casing in devtools. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/devtools/common/devtoolslib/http_server.py ('k') | mojo/devtools/common/devtoolslib/shell.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/devtoolslib/linux_shell.py
diff --git a/mojo/devtools/common/devtoolslib/linux_shell.py b/mojo/devtools/common/devtoolslib/linux_shell.py
index d37c46fa7bc8b2029f7682edcd5b803ea16004ef..d7c3bad52bea44f3a6780a28b8b99f87b42d98ee 100644
--- a/mojo/devtools/common/devtoolslib/linux_shell.py
+++ b/mojo/devtools/common/devtoolslib/linux_shell.py
@@ -24,25 +24,25 @@ class LinuxShell(Shell):
self.command_prefix = command_prefix if command_prefix else []
@overrides(Shell)
- def ServeLocalDirectory(self, local_dir_path, port=0):
+ def serve_local_directory(self, local_dir_path, port=0):
mappings = [('', local_dir_path)]
return 'http://%s:%d/' % http_server.start_http_server(mappings, port)
@overrides(Shell)
- def ServeLocalDirectories(self, mappings, port=0):
+ def serve_local_directories(self, mappings, port=0):
return 'http://%s:%d/' % http_server.start_http_server(mappings, port)
@overrides(Shell)
- def ForwardHostPortToShell(self, host_port):
+ def forward_host_port_to_shell(self, host_port):
pass
@overrides(Shell)
- def Run(self, arguments):
+ def run(self, arguments):
command = self.command_prefix + [self.executable_path] + arguments
return subprocess.call(command, stderr=subprocess.STDOUT)
@overrides(Shell)
- def RunAndGetOutput(self, arguments, timeout=None):
+ def run_and_get_output(self, arguments, timeout=None):
command = self.command_prefix + [self.executable_path] + arguments
p = subprocess.Popen(command, stdout=subprocess.PIPE,
stderr=subprocess.STDOUT)
« no previous file with comments | « mojo/devtools/common/devtoolslib/http_server.py ('k') | mojo/devtools/common/devtoolslib/shell.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698