mojo/devtools/common/devtoolslib/http_server.py - Issue 1268713005: Unify method name casing in devtools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/devtools/common/devtoolslib/http_server.py

Issue 1268713005: Unify method name casing in devtools. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/devtools/common/devtoolslib/http_server.py

diff --git a/mojo/devtools/common/devtoolslib/http_server.py b/mojo/devtools/common/devtoolslib/http_server.py

index 386b3569ac20c37e036719e23fdfa5fdc7d17359..dc125c835ebd57e000c412ddb7db05c247c1a1c3 100644

--- a/mojo/devtools/common/devtoolslib/http_server.py

+++ b/mojo/devtools/common/devtoolslib/http_server.py

@@ -49,7 +49,7 @@ class _SilentTCPServer(SocketServer.TCPServer):

SocketServer.TCPServer.handle_error(self, request, client_address)

-def _GetHandlerClassForPath(mappings):

+def _get_handler_class_for_path(mappings):

"""Creates a handler override for SimpleHTTPServer.

Args:

@@ -188,7 +188,7 @@ def start_http_server(mappings, host_port=0):

Tuple of the server address and the port on which it runs.

"""

assert mappings

- handler_class = _GetHandlerClassForPath(mappings)

+ handler_class = _get_handler_class_for_path(mappings)

try:

httpd = _SilentTCPServer(('127.0.0.1', host_port), handler_class)