Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: mojo/devtools/common/devtoolslib/shell.py

Issue 1268713005: Unify method name casing in devtools. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/devtools/common/devtoolslib/shell.py
diff --git a/mojo/devtools/common/devtoolslib/shell.py b/mojo/devtools/common/devtoolslib/shell.py
index 798208db32ee3911c2a623ae08d6a625d9ec88a3..0b542a7f598ac17d22660b0c319c01ca79639e25 100644
--- a/mojo/devtools/common/devtoolslib/shell.py
+++ b/mojo/devtools/common/devtoolslib/shell.py
@@ -6,7 +6,7 @@
class Shell(object):
"""Represents an abstract Mojo shell."""
- def ServeLocalDirectory(self, local_dir_path, port=0):
+ def serve_local_directory(self, local_dir_path, port=0):
"""Serves the content of the local (host) directory, making it available to
the shell under the url returned by the function.
@@ -22,7 +22,7 @@ class Shell(object):
"""
raise NotImplementedError()
- def ServeLocalDirectories(self, mappings, port=0):
+ def serve_local_directories(self, mappings, port=0):
"""Serves the content of the local (host) directories, making it available
to the shell under the url returned by the function.
@@ -41,7 +41,7 @@ class Shell(object):
"""
raise NotImplementedError()
- def ForwardHostPortToShell(self, host_port):
+ def forward_host_port_to_shell(self, host_port):
"""Forwards a port on the host machine to the same port wherever the shell
is running.
@@ -49,7 +49,7 @@ class Shell(object):
"""
raise NotImplementedError()
- def Run(self, arguments):
+ def run(self, arguments):
"""Runs the shell with given arguments until shell exits, passing the stdout
mingled with stderr produced by the shell onto the stdout.
@@ -59,7 +59,7 @@ class Shell(object):
"""
raise NotImplementedError()
- def RunAndGetOutput(self, arguments, timeout=None):
+ def run_and_get_output(self, arguments, timeout=None):
"""Runs the shell with given arguments until shell exits and returns the
output.
« no previous file with comments | « mojo/devtools/common/devtoolslib/linux_shell.py ('k') | mojo/devtools/common/devtoolslib/shell_arguments.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698