Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1268513005: GN: Fix missing dep (//ui/gl:test_support) in message_center_unittests (Closed)

Created:
5 years, 4 months ago by agrieve
Modified:
5 years, 4 months ago
Reviewers:
sadrul
CC:
chromium-reviews, peter+watch_chromium.org, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-all-qcms
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Fix missing dep (//ui/gl:test_support) in message_center_unittests BUG=507294 Committed: https://crrev.com/97d6cabe072f028ec7601a4090f23fa4dc03a12d Cr-Commit-Position: refs/heads/master@{#341272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/message_center/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
agrieve
5 years, 4 months ago (2015-07-30 18:50:21 UTC) #2
sadrul
lgtm Looks like you are fixing a bunch of these issues. Might be a good ...
5 years, 4 months ago (2015-07-30 20:28:25 UTC) #3
agrieve
On 2015/07/30 20:28:25, sadrul wrote: > lgtm > > Looks like you are fixing a ...
5 years, 4 months ago (2015-07-31 01:21:28 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 1264493004 Patch 1). Please resolve the dependency and ...
5 years, 4 months ago (2015-07-31 01:21:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268513005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268513005/1
5 years, 4 months ago (2015-07-31 02:16:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-31 02:46:29 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 02:47:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97d6cabe072f028ec7601a4090f23fa4dc03a12d
Cr-Commit-Position: refs/heads/master@{#341272}

Powered by Google App Engine
This is Rietveld 408576698