chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java - Issue 1268483004: Plumb the anonymize rect color to toolbar_layer from Tab#getThemeColor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Issue 1268483004: Plumb the anonymize rect color to toolbar_layer from Tab#getThemeColor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tabHasThemeColor

Patch Set: Renamed BrandColorUtils in implementation Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherDrawable.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

index 9b9ff8f5b1f67c0080b5438a6b46f6864c43e0c0..c79acbc0715371d6b38bd66f3da21e1ffa54eeb1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

@@ -954,8 +954,7 @@ public class ToolbarManager implements ToolbarTabController, UrlFocusChangeListe

int defaultPrimaryColor = isIncognito

? mToolbar.getResources().getColor(R.color.incognito_primary_color)

: mToolbar.getResources().getColor(R.color.default_primary_color);

- int primaryColor = (tab != null && tab.getWebContents() != null)

- ? tab.getWebContents().getThemeColor(defaultPrimaryColor) : defaultPrimaryColor;

+ int primaryColor = tab != null ? tab.getThemeColor() : defaultPrimaryColor;

updatePrimaryColor(primaryColor);

mToolbar.onTabOrModelChanged();