Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1268463003: CacheStorage: Temporary disable cache-match tests (Closed)

Created:
5 years, 4 months ago by nhiroki
Modified:
5 years, 4 months ago
Reviewers:
jkarlin
CC:
blink-reviews, serviceworker-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

CacheStorage: Temporary disable cache-match tests This CL temporary disables cache-match tests for updating Chromium-side implmentation of Match.matchAll(). (1) Blink: THIS PATCH (2) Chromium: https://codereview.chromium.org/1248003004/ (3) Blink: https://codereview.chromium.org/1262773003/ BUG=428363 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200129

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 2 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
nhiroki
PTAL, thanks!
5 years, 4 months ago (2015-08-05 08:03:57 UTC) #2
jkarlin
lgtm!
5 years, 4 months ago (2015-08-05 12:14:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268463003/1
5 years, 4 months ago (2015-08-06 15:33:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_rel/builds/45299)
5 years, 4 months ago (2015-08-06 15:35:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268463003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268463003/20001
5 years, 4 months ago (2015-08-06 15:48:30 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/65299)
5 years, 4 months ago (2015-08-06 17:01:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268463003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268463003/20001
5 years, 4 months ago (2015-08-06 22:28:09 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/39260)
5 years, 4 months ago (2015-08-06 22:33:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268463003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268463003/40001
5 years, 4 months ago (2015-08-06 22:42:24 UTC) #19
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 23:56:52 UTC) #20
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200129

Powered by Google App Engine
This is Rietveld 408576698