Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1262773003: CacheStorage: Update test expectations for Cache.matchAll() (Closed)

Created:
5 years, 4 months ago by nhiroki
Modified:
5 years, 4 months ago
Reviewers:
jkarlin
CC:
blink-reviews, serviceworker-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

CacheStorage: Update test expectations for Cache.matchAll() Cache.matchAll() was implemented behind a flag (see (2)). This CL updates test expectations. Note: CacheQueryOptions is not implemented yet, so some tests are still expected to fail. (1) Blink: https://codereview.chromium.org/1268463003/ (2) Chromium: https://codereview.chromium.org/1248003004/ (3) Blink: THIS PATCH BUG=428363 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200176

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -48 lines) Patch
M LayoutTests/TestExpectations View 1 2 chunks +1 line, -7 lines 0 comments Download
M LayoutTests/http/tests/cachestorage/script-tests/cache-match.js View 3 chunks +6 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/cachestorage/serviceworker/cache-match-expected.txt View 1 chunk +11 lines, -11 lines 0 comments Download
M LayoutTests/http/tests/cachestorage/window/cache-match-expected.txt View 1 chunk +11 lines, -11 lines 0 comments Download
M LayoutTests/http/tests/cachestorage/worker/cache-match-expected.txt View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
nhiroki
PTAL, thanks!
5 years, 4 months ago (2015-08-06 03:38:02 UTC) #5
jkarlin
lgtm
5 years, 4 months ago (2015-08-06 14:55:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262773003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262773003/80001
5 years, 4 months ago (2015-08-07 15:49:38 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 17:03:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200176

Powered by Google App Engine
This is Rietveld 408576698