Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 126793004: Update HTML classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, nessy, gavinp+prerender_chromium.org, philipj_slow, gasubic, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update HTML classes to use OVERRIDE / FINAL when needed Update HTML classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. R=esprehn, abarth BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+387 lines, -391 lines) Patch
M Source/core/html/ClassList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.h View 2 chunks +14 lines, -14 lines 0 comments Download
M Source/core/html/HTMLAreaElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLBRElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLBodyElement.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/html/HTMLButtonElement.h View 1 chunk +11 lines, -11 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLDetailsElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLElement.h View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLEmbedElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFieldSetElement.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.h View 5 chunks +18 lines, -18 lines 0 comments Download
M Source/core/html/HTMLFormControlElementWithState.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFormControlsCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFrameElement.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/html/HTMLFrameElementBase.h View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameSetElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLHRElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLIFrameElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLImageElement.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLImageLoader.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLImportChild.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLImportLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLImportsController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.h View 5 chunks +69 lines, -69 lines 0 comments Download
M Source/core/html/HTMLLabelElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLLegendElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMarqueeElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 11 chunks +73 lines, -73 lines 0 comments Download
M Source/core/html/HTMLMeterElement.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/HTMLObjectElement.h View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLOptGroupElement.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLOptionElement.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLOutputElement.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.h View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/html/HTMLProgressElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLScriptElement.h View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/core/html/HTMLSelectElement.h View 5 chunks +10 lines, -10 lines 0 comments Download
M Source/core/html/HTMLStyleElement.h View 1 chunk +7 lines, -8 lines 0 comments Download
M Source/core/html/HTMLSummaryElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.h View 2 chunks +18 lines, -18 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLTitleElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/LabelsNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/LinkImport.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/MediaController.h View 2 chunks +31 lines, -31 lines 0 comments Download
M Source/core/html/MediaKeyEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/PublicURLManager.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/TextDocument.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 11 months ago (2014-01-08 19:19:42 UTC) #1
esprehn
rslgtm
6 years, 11 months ago (2014-01-09 10:17:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/126793004/1
6 years, 11 months ago (2014-01-09 13:13:32 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 13:23:13 UTC) #4
Message was sent while issue was closed. 
Change committed as 164773

Powered by Google App Engine
This is Rietveld 408576698