Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: Source/core/html/HTMLFrameElementBase.h

Issue 126793004: Update HTML classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLFrameElement.h ('k') | Source/core/html/HTMLFrameOwnerElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Simon Hausmann <hausmann@kde.org> 4 * (C) 2000 Simon Hausmann <hausmann@kde.org>
5 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 16 matching lines...) Expand all
27 #include "core/html/HTMLFrameOwnerElement.h" 27 #include "core/html/HTMLFrameOwnerElement.h"
28 #include "platform/scroll/ScrollTypes.h" 28 #include "platform/scroll/ScrollTypes.h"
29 29
30 namespace WebCore { 30 namespace WebCore {
31 31
32 class HTMLFrameElementBase : public HTMLFrameOwnerElement { 32 class HTMLFrameElementBase : public HTMLFrameOwnerElement {
33 public: 33 public:
34 KURL location() const; 34 KURL location() const;
35 void setLocation(const String&); 35 void setLocation(const String&);
36 36
37 virtual ScrollbarMode scrollingMode() const { return m_scrolling; } 37 virtual ScrollbarMode scrollingMode() const OVERRIDE FINAL { return m_scroll ing; }
38 38
39 int marginWidth() const { return m_marginWidth; } 39 int marginWidth() const { return m_marginWidth; }
40 int marginHeight() const { return m_marginHeight; } 40 int marginHeight() const { return m_marginHeight; }
41 41
42 int width(); 42 int width();
43 int height(); 43 int height();
44 44
45 virtual bool canContainRangeEndPoint() const { return false; } 45 virtual bool canContainRangeEndPoint() const OVERRIDE FINAL { return false; }
46 46
47 protected: 47 protected:
48 HTMLFrameElementBase(const QualifiedName&, Document&); 48 HTMLFrameElementBase(const QualifiedName&, Document&);
49 49
50 bool isURLAllowed() const; 50 bool isURLAllowed() const;
51 51
52 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE; 52 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE;
53 virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE; 53 virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;
54 virtual void didNotifySubtreeInsertionsToDocument() OVERRIDE; 54 virtual void didNotifySubtreeInsertionsToDocument() OVERRIDE FINAL;
55 virtual void attach(const AttachContext& = AttachContext()) OVERRIDE; 55 virtual void attach(const AttachContext& = AttachContext()) OVERRIDE;
56 56
57 private: 57 private:
58 virtual bool supportsFocus() const; 58 virtual bool supportsFocus() const OVERRIDE FINAL;
59 virtual void setFocus(bool) OVERRIDE; 59 virtual void setFocus(bool) OVERRIDE FINAL;
60 60
61 virtual bool isURLAttribute(const Attribute&) const OVERRIDE; 61 virtual bool isURLAttribute(const Attribute&) const OVERRIDE FINAL;
62 virtual bool isHTMLContentAttribute(const Attribute&) const OVERRIDE; 62 virtual bool isHTMLContentAttribute(const Attribute&) const OVERRIDE FINAL;
63 63
64 virtual bool isFrameElementBase() const { return true; } 64 virtual bool isFrameElementBase() const OVERRIDE FINAL { return true; }
65 65
66 virtual bool areAuthorShadowsAllowed() const OVERRIDE { return false; } 66 virtual bool areAuthorShadowsAllowed() const OVERRIDE FINAL { return false; }
67 67
68 void setNameAndOpenURL(); 68 void setNameAndOpenURL();
69 void openURL(bool lockBackForwardList = true); 69 void openURL(bool lockBackForwardList = true);
70 70
71 AtomicString m_URL; 71 AtomicString m_URL;
72 AtomicString m_frameName; 72 AtomicString m_frameName;
73 73
74 ScrollbarMode m_scrolling; 74 ScrollbarMode m_scrolling;
75 75
76 int m_marginWidth; 76 int m_marginWidth;
77 int m_marginHeight; 77 int m_marginHeight;
78 }; 78 };
79 79
80 inline bool isHTMLFrameElementBase(const Node& node) 80 inline bool isHTMLFrameElementBase(const Node& node)
81 { 81 {
82 return node.isElementNode() && toElement(node).isFrameElementBase(); 82 return node.isElementNode() && toElement(node).isFrameElementBase();
83 } 83 }
84 84
85 DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION(HTMLFrameElementBase); 85 DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION(HTMLFrameElementBase);
86 86
87 } // namespace WebCore 87 } // namespace WebCore
88 88
89 #endif // HTMLFrameElementBase_h 89 #endif // HTMLFrameElementBase_h
OLDNEW
« no previous file with comments | « Source/core/html/HTMLFrameElement.h ('k') | Source/core/html/HTMLFrameOwnerElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698