Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Unified Diff: Source/core/html/HTMLSelectElement.h

Issue 126793004: Update HTML classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLScriptElement.h ('k') | Source/core/html/HTMLStyleElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLSelectElement.h
diff --git a/Source/core/html/HTMLSelectElement.h b/Source/core/html/HTMLSelectElement.h
index 1462bdb709e53a3bab233ef1e81280b053fa7647..ebb30b4b184ddccb1890f1222ef669051eff4737 100644
--- a/Source/core/html/HTMLSelectElement.h
+++ b/Source/core/html/HTMLSelectElement.h
@@ -80,7 +80,7 @@ public:
const Vector<HTMLElement*>& listItems() const;
- virtual void accessKeyAction(bool sendMouseEvents);
+ virtual void accessKeyAction(bool sendMouseEvents) OVERRIDE;
void accessKeySetSelectedIndex(int);
void setMultiple(bool);
@@ -118,16 +118,16 @@ protected:
HTMLSelectElement(Document&, HTMLFormElement*, bool createdByParser);
private:
- virtual const AtomicString& formControlType() const;
+ virtual const AtomicString& formControlType() const OVERRIDE;
virtual bool shouldShowFocusRingOnMouseFocus() const OVERRIDE;
virtual void dispatchFocusEvent(Element* oldFocusedElement, FocusDirection) OVERRIDE;
virtual void dispatchBlurEvent(Element* newFocusedElemnet) OVERRIDE;
- virtual bool canStartSelection() const { return false; }
+ virtual bool canStartSelection() const OVERRIDE { return false; }
- virtual bool isEnumeratable() const { return true; }
+ virtual bool isEnumeratable() const OVERRIDE { return true; }
virtual bool isInteractiveContent() const OVERRIDE;
virtual bool supportLabels() const OVERRIDE { return true; }
@@ -137,10 +137,10 @@ private:
virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERRIDE;
virtual bool isPresentationAttribute(const QualifiedName&) const OVERRIDE;
- virtual RenderObject* createRenderer(RenderStyle *);
- virtual bool appendFormData(FormDataList&, bool);
+ virtual RenderObject* createRenderer(RenderStyle*) OVERRIDE;
+ virtual bool appendFormData(FormDataList&, bool) OVERRIDE;
- virtual void defaultEventHandler(Event*);
+ virtual void defaultEventHandler(Event*) OVERRIDE;
void dispatchChangeEventForMenuList();
@@ -152,8 +152,8 @@ private:
virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;
- virtual bool isOptionalFormControl() const { return !isRequiredFormControl(); }
- virtual bool isRequiredFormControl() const;
+ virtual bool isOptionalFormControl() const OVERRIDE { return !isRequiredFormControl(); }
+ virtual bool isRequiredFormControl() const OVERRIDE;
bool hasPlaceholderLabelOption() const;
@@ -185,7 +185,7 @@ private:
int lastSelectableListIndex() const;
int nextSelectableListIndexPageAway(int startIndex, SkipDirection) const;
- virtual void childrenChanged(bool changedByParser = false, Node* beforeChange = 0, Node* afterChange = 0, int childCountDelta = 0);
+ virtual void childrenChanged(bool changedByParser = false, Node* beforeChange = 0, Node* afterChange = 0, int childCountDelta = 0) OVERRIDE;
virtual bool areAuthorShadowsAllowed() const OVERRIDE { return false; }
virtual void finishParsingChildren() OVERRIDE;
« no previous file with comments | « Source/core/html/HTMLScriptElement.h ('k') | Source/core/html/HTMLStyleElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698