Force all font backends to override onGetFontDescriptor, so we can

Force all font backends to override onGetFontDescriptor, so we can
eliminate SkFontHost::Serialize and Deserialize

[bungeman-skia, 2013-03-22 21:04:04]

https://codereview.chromium.org/12676024/diff/1/include/core/SkTypeface.h
File include/core/SkTypeface.h (right):

https://codereview.chromium.org/12676024/diff/1/include/core/SkTypeface.h#new...
include/core/SkTypeface.h:221: virtual void
onGetFontDescriptor(SkFontDescriptor*, bool* isLocal) const = 0;
I know isLocal describes what it is usually used for, but I prefer something
like "embed" since this really just determines if the data should be embeded or
not.

https://codereview.chromium.org/12676024/diff/1/src/core/SkTypeface.cpp
File src/core/SkTypeface.cpp (right):

https://codereview.chromium.org/12676024/diff/1/src/core/SkTypeface.cpp#newco...
src/core/SkTypeface.cpp:99: int ttcIndex;   // TODO: write this to the stream?
Yes, we need a issue to track this.

https://codereview.chromium.org/12676024/diff/1/src/core/SkTypeface.cpp#newco...
src/core/SkTypeface.cpp:121: return
SkTypeface::CreateFromStream(localStream.get());
In the same issue, or maybe here in comment, note that we need to read the
ttcIndex from the stream and pass it to CreateFromStream (as a new optional?
parameter).

https://codereview.chromium.org/12676024/diff/1/src/ports/SkFontHost_android.cpp
File src/ports/SkFontHost_android.cpp (right):

https://codereview.chromium.org/12676024/diff/1/src/ports/SkFontHost_android....
src/ports/SkFontHost_android.cpp:753: #if 0   // do we need this different name
lookup for Deserialize?
Should we ask djsollen about this?

[reed1, 2013-03-25 12:26:27]

https://codereview.chromium.org/12676024/diff/1/include/core/SkTypeface.h
File include/core/SkTypeface.h (right):

https://codereview.chromium.org/12676024/diff/1/include/core/SkTypeface.h#new...
include/core/SkTypeface.h:221: virtual void
onGetFontDescriptor(SkFontDescriptor*, bool* isLocal) const = 0;
On 2013/03/22 21:04:05, bungeman1 wrote:
> I know isLocal describes what it is usually used for, but I prefer something
> like "embed" since this really just determines if the data should be embeded
or
> not.

Not so sure. I think the call should return information about the font, and
leave the "should" decisions to the caller (since in the case of serialization,
we may embed 'system' fonts as well).

Either way, this is a protected method, and no doubt we will evolve it (and
fontdescriptor itself) over time.

https://codereview.chromium.org/12676024/diff/1/src/core/SkTypeface.cpp
File src/core/SkTypeface.cpp (right):

https://codereview.chromium.org/12676024/diff/1/src/core/SkTypeface.cpp#newco...
src/core/SkTypeface.cpp:99: int ttcIndex;   // TODO: write this to the stream?
On 2013/03/22 21:04:05, bungeman1 wrote:
> Yes, we need a issue to track this.

Done.

https://codereview.chromium.org/12676024/diff/1/src/core/SkTypeface.cpp#newco...
src/core/SkTypeface.cpp:121: return
SkTypeface::CreateFromStream(localStream.get());
On 2013/03/22 21:04:05, bungeman1 wrote:
> In the same issue, or maybe here in comment, note that we need to read the
> ttcIndex from the stream and pass it to CreateFromStream (as a new optional?
> parameter).

Done.

https://codereview.chromium.org/12676024/diff/1/src/ports/SkFontHost_android.cpp
File src/ports/SkFontHost_android.cpp (right):

https://codereview.chromium.org/12676024/diff/1/src/ports/SkFontHost_android....
src/ports/SkFontHost_android.cpp:753: #if 0   // do we need this different name
lookup for Deserialize?
On 2013/03/22 21:04:05, bungeman1 wrote:
> Should we ask djsollen about this?

Done.

[reed1, 2013-03-25 13:49:00]

landed in rev. 8359