Force all font backends to override onGetFontDescriptor, so we can

include/core/SkTypeface.h

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #ifndef SkTypeface_DEFINED
@@ skipping 200 matching lines @@
     friend class SkScalerContext;
     static SkTypeface* GetDefaultTypeface();
 
     virtual SkScalerContext* onCreateScalerContext(const SkDescriptor*) const = 0;
     virtual void onFilterRec(SkScalerContextRec*) const = 0;
     virtual SkAdvancedTypefaceMetrics* onGetAdvancedTypefaceMetrics(
                         SkAdvancedTypefaceMetrics::PerGlyphInfo perGlyphInfo,
                         const uint32_t* glyphIDs,
                         uint32_t glyphIDsCount) const = 0;
     virtual SkStream* onOpenStream(int* ttcIndex) const = 0;
+    virtual void onGetFontDescriptor(SkFontDescriptor*, bool* isLocal) const = 0;

[bungeman-skia, 2013/03/22 21:04:05]

I know isLocal describes what it is usually used for, but I prefer something
like "embed" since this really just determines if the data should be embeded or
not.

[reed1, 2013/03/25 12:26:27]

Not so sure. I think the call should return information about the font, and
leave the "should" decisions to the caller (since in the case of serialization,
we may embed 'system' fonts as well).

Either way, this is a protected method, and no doubt we will evolve it (and
fontdescriptor itself) over time.

 
     virtual int onGetUPEM() const;
 
     virtual int onGetTableTags(SkFontTableTag tags[]) const;
     virtual size_t onGetTableData(SkFontTableTag, size_t offset,
                                   size_t length, void* data) const;
-    virtual void onGetFontDescriptor(SkFontDescriptor*) const;
 
 private:
     SkFontID    fUniqueID;
     Style       fStyle;
     bool        fIsFixedWidth;
 
     friend class SkPaint;
     friend class SkGlyphCache;  // GetDefaultTypeface
     // just so deprecated fonthost can call protected methods
     friend class SkFontHost;
 
     typedef SkWeakRefCnt INHERITED;
 };
 
 #endif