Force all font backends to override onGetFontDescriptor, so we can

include/core/SkTypeface.h

Index: include/core/SkTypeface.h
===================================================================
--- include/core/SkTypeface.h	(revision 8346)
+++ include/core/SkTypeface.h	(working copy)
@@ -218,13 +218,13 @@
                         const uint32_t* glyphIDs,
                         uint32_t glyphIDsCount) const = 0;
     virtual SkStream* onOpenStream(int* ttcIndex) const = 0;
+    virtual void onGetFontDescriptor(SkFontDescriptor*, bool* isLocal) const = 0;

[bungeman-skia, 2013/03/22 21:04:05]

I know isLocal describes what it is usually used for, but I prefer something
like "embed" since this really just determines if the data should be embeded or
not.

[reed1, 2013/03/25 12:26:27]

Not so sure. I think the call should return information about the font, and
leave the "should" decisions to the caller (since in the case of serialization,
we may embed 'system' fonts as well).

Either way, this is a protected method, and no doubt we will evolve it (and
fontdescriptor itself) over time.

 
     virtual int onGetUPEM() const;
 
     virtual int onGetTableTags(SkFontTableTag tags[]) const;
     virtual size_t onGetTableData(SkFontTableTag, size_t offset,
                                   size_t length, void* data) const;
-    virtual void onGetFontDescriptor(SkFontDescriptor*) const;
 
 private:
     SkFontID    fUniqueID;