Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1267583003: Fix gn gen for iOS. (Closed)

Created:
5 years, 4 months ago by sherouk
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke, sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gn gen for iOS. BUG=459705 Committed: https://crrev.com/53f0f1ac021043f7aba990be4a44de21e18eebe8 Cr-Commit-Position: refs/heads/master@{#341530}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -99 lines) Patch
M BUILD.gn View 3 chunks +103 lines, -98 lines 0 comments Download
M build/config/features.gni View 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 1257303005 Patch 1
Issue 1271513006 Patch 1
Issue 1257303005 Patch 40001

Messages

Total messages: 10 (4 generated)
sherouk
Can you review please?
5 years, 4 months ago (2015-08-03 14:45:59 UTC) #2
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-03 15:01:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267583003/1
5 years, 4 months ago (2015-08-03 15:10:47 UTC) #7
sdefresne
lgtm
5 years, 4 months ago (2015-08-03 15:20:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-03 15:59:47 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 16:00:26 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/53f0f1ac021043f7aba990be4a44de21e18eebe8
Cr-Commit-Position: refs/heads/master@{#341530}

Powered by Google App Engine
This is Rietveld 408576698