Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1271513006: Adding sync to dependencies on iOS. (Closed)

Created:
5 years, 4 months ago by sherouk
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke, sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@Editing_IOS_dependencies
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding sync to dependencies on iOS. BUG=459705 Committed: https://crrev.com/d0f710fa5c3c14ea50408774fd685777157e8765 Cr-Commit-Position: refs/heads/master@{#341875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
sherouk
Can you review please?
5 years, 4 months ago (2015-08-04 17:21:51 UTC) #2
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-04 18:14:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271513006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271513006/1
5 years, 4 months ago (2015-08-05 08:55:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-05 09:45:45 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d0f710fa5c3c14ea50408774fd685777157e8765 Cr-Commit-Position: refs/heads/master@{#341875}
5 years, 4 months ago (2015-08-05 09:46:29 UTC) #7
sdefresne
5 years, 4 months ago (2015-08-05 10:01:19 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698