Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1257303005: Editing iOS sources and dependencies. (Closed)

Created:
5 years, 4 months ago by sherouk
Modified:
5 years, 4 months ago
CC:
chromium-reviews, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Editing_IOS_dependencies
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Editing iOS sources and dependencies for //base. Build "base_i18n_perftests" and "base_perftests" on iOS. Check that the list of files build with gn and gyp are the same. BUG=459705 Committed: https://crrev.com/e1859f9e90fc21052aacdb08698ed72a332773fc Cr-Commit-Position: refs/heads/master@{#341877}

Patch Set 1 #

Total comments: 1

Patch Set 2 : set_sources_assignment_filter(sources_assignment_filter) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -9 lines) Patch
M BUILD.gn View 1 chunk +7 lines, -2 lines 0 comments Download
M base/BUILD.gn View 1 5 chunks +27 lines, -7 lines 0 comments Download
M base/memory/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M base/test/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
sherouk
Can you review please?
5 years, 4 months ago (2015-08-04 14:52:26 UTC) #2
Dirk Pranke
lgtm, but you probably need an OWNERS review from someone like Brett.
5 years, 4 months ago (2015-08-04 15:06:46 UTC) #4
sdefresne
lgtm, please wait for brettw review
5 years, 4 months ago (2015-08-04 15:25:27 UTC) #5
brettw
lgtm https://codereview.chromium.org/1257303005/diff/1/base/BUILD.gn File base/BUILD.gn (right): https://codereview.chromium.org/1257303005/diff/1/base/BUILD.gn#newcode654 base/BUILD.gn:654: set_sources_assignment_filter([]) This should be: set_sources_assignment_filter(sources_assignment_filter) to put back ...
5 years, 4 months ago (2015-08-04 17:43:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257303005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257303005/40001
5 years, 4 months ago (2015-08-05 09:23:02 UTC) #10
sdefresne
still lgtm
5 years, 4 months ago (2015-08-05 10:02:13 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 4 months ago (2015-08-05 10:20:06 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 10:23:16 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1859f9e90fc21052aacdb08698ed72a332773fc
Cr-Commit-Position: refs/heads/master@{#341877}

Powered by Google App Engine
This is Rietveld 408576698