DescriptionRevert of Create classes_util API, change discover to return a list instead of a dict. (patchset #2 id:280001 of https://codereview.chromium.org/1262623007/ )
Reason for revert:
fails reliably on XP tests: https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20(1)/builds/39209/steps/telemetry_perf_unittests/logs/stdio
Original issue's description:
> Reland of Create classes_util API, change discover to return a list instead of a dict. (patchset #1 id:1 of https://codereview.chromium.org/1263063003/)
>
> Reason for revert:
> The telemetry tests aren't broken. The perf_unittests are because they don't pick tests in a deterministic way. Reverting after a change to make them deterministic.
>
> Original issue's description:
> > Revert of Create classes_util API, change discover to return a list instead of a dict. (patchset #5 id:120001 of https://codereview.chromium.org/1244223002/)
> >
> > Reason for revert:
> > This appears to break the XP telemetry tests. Details on the bug.
> >
> > Original issue's description:
> > > Create classes_util API, change discover to return a list instead of a dict.
> > >
> > > BUG=498968
> > > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
> > >
> > > Committed: https://crrev.com/e6cbec4747aa7fe3c96b1cdb89de21ae77b30ab0
> > > Cr-Commit-Position: refs/heads/master@{#341129}
> >
> > TBR=dtu@chromium.org,bengr@chromium.org,aiolos@chromium.org
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=498968
> >
> > Committed: https://crrev.com/c85e3e1af7e170d5f8ec2b012df6e9337d2352bb
> > Cr-Commit-Position: refs/heads/master@{#341218}
>
> TBR=dtu@chromium.org,bengr@chromium.org,avi@chromium.org
> BUG=498968
>
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
>
> Committed: https://crrev.com/7e6fefcf3b839256c97e2e7bc0bfc3c53af75c8d
> Cr-Commit-Position: refs/heads/master@{#341646}
TBR=dtu@chromium.org,bengr@chromium.org,avi@chromium.org,aiolos@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=498968
Committed: https://crrev.com/bf85d83ff178f0ce51e4f91641ab7887397a5e20
Cr-Commit-Position: refs/heads/master@{#341692}
Patch Set 1 #
Created: 5 years, 4 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|