Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 12662038: Revert 187936 "Pass more detailed audio hardware configuration i..." (Closed)

Created:
7 years, 9 months ago by kareng
Modified:
7 years, 9 months ago
Reviewers:
Chris Rogers
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, sail+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Revert 187936 "Pass more detailed audio hardware configuration i..." > Pass more detailed audio hardware configuration information to the renderer > > AudioHardwareConfig currently contains an ad-hoc mix of pieces of information about > the audio input and output hardware. This CL adds more complete and symmetric information > about the audio hardware as tracked in AudioHardwareConfig. > > The ChannelMixer is also upgraded to allow for "discrete" up and down mixing. > > BUG=none > TEST=manual - several tests updated > Review URL: https://codereview.chromium.org/12387006 TBR=crogers@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189877

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -462 lines) Patch
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M content/common/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/media/media_param_traits.h View 3 chunks +2 lines, -3 lines 0 comments Download
M content/common/media/media_param_traits.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/view_messages.h View 2 chunks +6 lines, -5 lines 0 comments Download
M content/renderer/media/audio_message_filter.cc View 1 chunk +1 line, -16 lines 0 comments Download
M content/renderer/media/audio_renderer_mixer_manager_unittest.cc View 2 chunks +1 line, -12 lines 0 comments Download
M content/renderer/media/webrtc_audio_capturer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_unittest.cc View 3 chunks +6 lines, -19 lines 0 comments Download
M content/renderer/media/webrtc_audio_renderer.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/pepper/pepper_platform_audio_input_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/test/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/webrtc_audio_device_test.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/test/webrtc_audio_device_test.cc View 4 chunks +9 lines, -7 lines 0 comments Download
MM media/audio/audio_output_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_resampler.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_parameters.h View 2 chunks +1 line, -4 lines 0 comments Download
M media/audio/audio_parameters.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M media/audio/mac/audio_manager_mac.h View 1 chunk +0 lines, -10 lines 0 comments Download
M media/audio/mac/audio_manager_mac.cc View 3 chunks +8 lines, -116 lines 0 comments Download
M media/base/audio_converter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/audio_hardware_config.h View 2 chunks +14 lines, -19 lines 0 comments Download
M media/base/audio_hardware_config.cc View 1 chunk +26 lines, -53 lines 0 comments Download
M media/base/audio_hardware_config_unittest.cc View 3 chunks +8 lines, -48 lines 0 comments Download
MM media/base/channel_layout.h View 2 chunks +0 lines, -7 lines 0 comments Download
MM media/base/channel_layout.cc View 3 chunks +0 lines, -29 lines 0 comments Download
M media/base/channel_mixer.h View 2 chunks +1 line, -6 lines 0 comments Download
M media/base/channel_mixer.cc View 8 chunks +17 lines, -53 lines 0 comments Download
M media/base/channel_mixer_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/ffmpeg/ffmpeg_common.cc View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kareng
7 years, 9 months ago (2013-03-22 19:33:13 UTC) #1
kareng
7 years, 9 months ago (2013-03-22 19:34:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r189877.

Powered by Google App Engine
This is Rietveld 408576698