content/renderer/media/webrtc_audio_renderer.cc - Issue 12662038: Revert 187936 "Pass more detailed audio hardware configuration i..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_audio_renderer.cc

Issue 12662038: Revert 187936 "Pass more detailed audio hardware configuration i..." (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1440/src/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc_audio_device_unittest.cc ('k') | content/renderer/pepper/pepper_platform_audio_input_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc_audio_renderer.cc

===================================================================

--- content/renderer/media/webrtc_audio_renderer.cc (revision 189875)

+++ content/renderer/media/webrtc_audio_renderer.cc (working copy)

@@ -158,10 +158,8 @@

return false;

}

- int channels = ChannelLayoutToChannelCount(channel_layout);

source_params.Reset(media::AudioParameters::AUDIO_PCM_LOW_LATENCY,

- channel_layout, channels, 0,

- sample_rate, 16, buffer_size);

+ channel_layout, 0, sample_rate, 16, buffer_size);

// Set up audio parameters for the sink, i.e., the native audio output stream.

// We strive to open up using native parameters to achieve best possible

@@ -173,7 +171,7 @@

buffer_size = hardware_config->GetOutputBufferSize();

sink_params.Reset(media::AudioParameters::AUDIO_PCM_LOW_LATENCY,

- channel_layout, channels, 0, sample_rate, 16, buffer_size);

+ channel_layout, 0, sample_rate, 16, buffer_size);

// Create a FIFO if re-buffering is required to match the source input with

// the sink request. The source acts as provider here and the sink as