lock pixels in image when bitmap is immutable and not-lazy

lock pixels in image when bitmap is immutable and not-lazy

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/02d91d187324cd0f014a78eab1ca09ec71a9b356

[reed2, 2015-07-31 02:49:24]

The CQ bit was checked by reed@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-31 02:49:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1266143003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1266143003/1

[reed2, 2015-07-31 02:55:28]

The CQ bit was unchecked by reed@chromium.org

[reed2, 2015-07-31 02:57:32]

reed@chromium.org changed reviewers:
+ fmalita@chromium.org

[reed2, 2015-07-31 02:57:32]

ptal

[reed2, 2015-07-31 02:57:37]

The CQ bit was checked by reed@chromium.org

[commit-bot: I haz the power, 2015-07-31 02:57:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1266143003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1266143003/20001

[commit-bot: I haz the power, 2015-07-31 02:57:45]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-07-31 08:57 UTC

[reed2, 2015-07-31 02:57:54]

reed@chromium.org changed reviewers:
+ reed@google.com

[f(malita), 2015-07-31 03:12:24]

lgtm

https://codereview.chromium.org/1266143003/diff/20001/tests/DeferredCanvasTes...
File tests/DeferredCanvasTest.cpp (left):

https://codereview.chromium.org/1266143003/diff/20001/tests/DeferredCanvasTes...
tests/DeferredCanvasTest.cpp:67: return SkNewImageFromRasterBitmap(fBitmap,
&this->props(), kUnlocked_SharedPixelRefMode);
Just making sure: this is no longer necessary because your prev CL made raster
snapshots immutable, right? (hopefully there's a test for it)

[commit-bot: I haz the power, 2015-07-31 03:13:47]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/02d91d187324cd0f014a78eab1ca09ec71a9b356

[f(malita), 2015-07-31 03:16:18]

On 2015/07/31 03:12:24, f(malita) wrote:
> lgtm
> 
>
https://codereview.chromium.org/1266143003/diff/20001/tests/DeferredCanvasTes...
> File tests/DeferredCanvasTest.cpp (left):
> 
>
https://codereview.chromium.org/1266143003/diff/20001/tests/DeferredCanvasTes...
> tests/DeferredCanvasTest.cpp:67: return SkNewImageFromRasterBitmap(fBitmap,
> &this->props(), kUnlocked_SharedPixelRefMode);
> Just making sure: this is no longer necessary because your prev CL made raster
> snapshots immutable, right? (hopefully there's a test for it)

Never mind, I think immutability is irrelevant here but the prelock test
supersedes this flag.

[reed2, 2015-07-31 03:32:31]

On 2015/07/31 03:12:24, f(malita) wrote:
> lgtm
> 
>
https://codereview.chromium.org/1266143003/diff/20001/tests/DeferredCanvasTes...
> File tests/DeferredCanvasTest.cpp (left):
> 
>
https://codereview.chromium.org/1266143003/diff/20001/tests/DeferredCanvasTes...
> tests/DeferredCanvasTest.cpp:67: return SkNewImageFromRasterBitmap(fBitmap,
> &this->props(), kUnlocked_SharedPixelRefMode);
> Just making sure: this is no longer necessary because your prev CL made raster
> snapshots immutable, right? (hopefully there's a test for it)

We don't have an API to query an image for "immutable" -- as they are defined to
be such.

I did add asserts in all (hopefully) constructors that the bitmap is in fact
immutable (at least by the time it is in the image).