tests/DeferredCanvasTest.cpp - Issue 1266143003: lock pixels in image when bitmap is immutable and not-lazy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/DeferredCanvasTest.cpp

Issue 1266143003: lock pixels in image when bitmap is immutable and not-lazy (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/DeferredCanvasTest.cpp

diff --git a/tests/DeferredCanvasTest.cpp b/tests/DeferredCanvasTest.cpp

index 882871fa4d24ae7ca6b00fffce9cd4c0ceb6a665..eb2263ef2ba386578abbd150c09ae3705ced7976 100644

--- a/tests/DeferredCanvasTest.cpp

+++ b/tests/DeferredCanvasTest.cpp

@@ -64,7 +64,7 @@ public:

}

SkImage* onNewImageSnapshot(Budgeted) override {

- return SkNewImageFromRasterBitmap(fBitmap, &this->props(), kUnlocked_SharedPixelRefMode);

f(malita) 2015/07/31 03:12:24 Just making sure: this is no longer necessary beca

+ return SkNewImageFromRasterBitmap(fBitmap, &this->props());

}

void onCopyOnWrite(ContentChangeMode mode) override {

« no previous file with comments | « src/image/SkSurface_Raster.cpp ('k') | tests/ImageTest.cpp » ('j') | no next file with comments »