tests/ImageTest.cpp - Issue 1266143003: lock pixels in image when bitmap is immutable and not-lazy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/ImageTest.cpp

Issue 1266143003: lock pixels in image when bitmap is immutable and not-lazy (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/ImageTest.cpp

diff --git a/tests/ImageTest.cpp b/tests/ImageTest.cpp

index 5da83429952294acaad611da34b45f1b918609d3..ba071bb1f75ca6f878eba49e728fcc3edcb454ea 100644

--- a/tests/ImageTest.cpp

+++ b/tests/ImageTest.cpp

@@ -245,9 +245,7 @@ DEF_TEST(image_newfrombitmap, reporter) {

const bool sharedID = (image->uniqueID() == bm.getGenerationID());

REPORTER_ASSERT(reporter, sharedID == rec[i].fExpectSharedID);

-#if 0 // TODO: fix so that peek will succeed in the immutable case

const bool peekSuccess = image->peekPixels(&pmap);

REPORTER_ASSERT(reporter, peekSuccess == rec[i].fExpectPeekSuccess);

-#endif

}