IWYU: 'core' target, files starting A-C.

IWYU: 'core' target, files starting A-C.

TBR=reed@google.com
Verbal lgtm, does not change API.

Committed: https://skia.googlesource.com/skia/+/7403d87db8e43d4c2b5b25ac22a0ebc22bd09d69

Committed: https://skia.googlesource.com/skia/+/d3ebb48320cf1b7e969974673e4bd7743816985e

[bungeman-skia, 2015-07-31 19:16:34]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-31 19:16:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1265033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1265033002/20001

[commit-bot: I haz the power, 2015-07-31 19:27:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-31 19:27:53]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[bungeman-skia, 2015-07-31 19:46:27]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-31 19:46:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1265033002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1265033002/40001

[bungeman-skia, 2015-07-31 19:52:53]

The CQ bit was unchecked by bungeman@google.com

[bungeman-skia, 2015-07-31 20:08:20]

bungeman@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[bungeman-skia, 2015-07-31 20:08:21]

Patch Set 1 is the 'real' change, Patch Set 3 contains Patch Set 1 and all the
knock on changes to keep things building.

I now realize the approach taken here is the wrong way around. When using iwyu
one should start with the 'leaves' and work inward so that each file is touched
only once. However, I started from 'root' here to learn early if there were any
surprises. Future changes should be less noisy, but I'd like to get feedback on
this first.

While this mostly looks trivial, once the noise is reduced, real oddities are
found. Also, I'd like to know if the general approach and look of the proposed
changes is acceptable.

[mtklein, 2015-07-31 23:12:06]

lgtm

I'm totally on board, with the caveat that I reviewed this somewhat
stochastically, looking more at files with more lines changed.

https://codereview.chromium.org/1265033002/diff/40001/include/core/SkPostConf...
File include/core/SkPostConfig.h (right):

https://codereview.chromium.org/1265033002/diff/40001/include/core/SkPostConf...
include/core/SkPostConfig.h:8: // IWYU pragma: private, include "SkTypes.h"
NEAT.  This says, include SkTypes.h if you think you need to include this,
right?

https://codereview.chromium.org/1265033002/diff/40001/src/core/SkBitmap.cpp
File src/core/SkBitmap.cpp (right):

https://codereview.chromium.org/1265033002/diff/40001/src/core/SkBitmap.cpp#n...
src/core/SkBitmap.cpp:1219: #include "SkString.h"
Was this automatic, or you?

https://codereview.chromium.org/1265033002/diff/40001/tests/CanvasStateTest.cpp
File tests/CanvasStateTest.cpp (right):

https://codereview.chromium.org/1265033002/diff/40001/tests/CanvasStateTest.c...
tests/CanvasStateTest.cpp:305: #include "SkClipStack.h"
Same question... tool or you?

[bungeman-skia, 2015-08-03 15:34:15]

As a note, this does break Chrome, mostly skia/ext. I'll fix up Chrome side
before landing any of this.

https://codereview.chromium.org/1265033002/diff/40001/include/core/SkPostConf...
File include/core/SkPostConfig.h (right):

https://codereview.chromium.org/1265033002/diff/40001/include/core/SkPostConf...
include/core/SkPostConfig.h:8: // IWYU pragma: private, include "SkTypes.h"
On 2015/07/31 23:12:06, mtklein wrote:
> NEAT.  This says, include SkTypes.h if you think you need to include this,
> right?

Yes. It does two things from the user perspective. The first is that if someone
directly types '#include SkPostConfig.h' iwyu will complain and tell you to
include SkTypes.h instead. The other part is this tells iwyu that even if you
don't use anything from SkTypes.h (which exports SkPostConfig.h) not to suggest
SkPostConfig.h as an include. This came up once, which is why I added these.

On a related note you can mark headers as private and then add 'friend' pragmas
(which are path globs) for those not-quite-public headers.

https://codereview.chromium.org/1265033002/diff/40001/src/core/SkBitmap.cpp
File src/core/SkBitmap.cpp (right):

https://codereview.chromium.org/1265033002/diff/40001/src/core/SkBitmap.cpp#n...
src/core/SkBitmap.cpp:1219: #include "SkString.h"
On 2015/07/31 23:12:06, mtklein wrote:
> Was this automatic, or you?

The tool itself wanted to add SkString.h at the top, but it seemed a strange
include to me, so I stuck it down here. So the suggestion of inclusion was the
tool's, but the placement is mine. In theory, these can be found by getting
everything iwyu clean on one configuration, and then try various other
configurations and see how they conflict.

https://codereview.chromium.org/1265033002/diff/40001/tests/CanvasStateTest.cpp
File tests/CanvasStateTest.cpp (right):

https://codereview.chromium.org/1265033002/diff/40001/tests/CanvasStateTest.c...
tests/CanvasStateTest.cpp:305: #include "SkClipStack.h"
On 2015/07/31 23:12:06, mtklein wrote:
> Same question... tool or you?

This is just me (as with everything not mentioned in Patch Set 1). This was
added simply for this file to compile (since SkClipStack is a forward declared
in SkCanvas instead of included).

[bungeman-skia, 2015-08-04 18:04:27]

This should no longer be blocked by Chrome or Android. Take a look.

[mtklein, 2015-08-04 18:15:48]

lgtm

[bungeman-skia, 2015-08-04 21:32:24]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-08-04 21:32:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1265033002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1265033002/60001

[commit-bot: I haz the power, 2015-08-04 21:33:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 21:33:13]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)

[bungeman-skia, 2015-08-04 21:49:02]

The CQ bit was checked by bungeman@google.com

[bungeman-skia, 2015-08-04 21:49:02]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1265033002/#ps80001
(title: "Rebase (a file was deleted).")

[commit-bot: I haz the power, 2015-08-04 21:49:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1265033002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1265033002/80001

[commit-bot: I haz the power, 2015-08-04 21:57:04]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/7403d87db8e43d4c2b5b25ac22a0ebc22bd09d69

[reed2, 2015-08-05 01:44:16]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1273613002/ by reed@chromium.org.

The reason for reverting is: revert to unblock DEPS roll

../../chrome/browser/chromeos/display/overscan_calibrator.cc:43:10: error:
variable has incomplete type 'SkPath'
  SkPath base_path;
.

[bungeman-skia, 2015-08-05 20:56:05]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-08-05 20:56:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1265033002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1265033002/80001

[commit-bot: I haz the power, 2015-08-05 20:57:53]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/d3ebb48320cf1b7e969974673e4bd7743816985e