Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 126453006: aw: Clean up android webview lint suppressions (Closed)

Created:
6 years, 11 months ago by boliu
Modified:
6 years, 11 months ago
Reviewers:
frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, android-webview-reviews_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

aw: Clean up android webview lint suppressions Fix a few instances of HashMap to SparseArray in AwQuotaManagerBridge.java Pass null locale to String.format, which implies "no localization is applied". Pass Locale.ENGLISH toLowerCase as suggested by the documentation. Removed some unneeded supressions. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243781

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove AwQuotaManagerBridge.java from suppression #

Patch Set 3 : Fix tests as well #

Patch Set 4 : Remove .class from suppression #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -31 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwQuotaManagerBridge.java View 6 chunks +19 lines, -18 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwViewportTest.java View 1 2 5 chunks +12 lines, -7 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java View 1 2 3 chunks +4 lines, -2 lines 1 comment Download
M build/android/lint/suppressions.xml View 1 2 3 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
boliu
6 years, 11 months ago (2014-01-08 20:36:46 UTC) #1
frankf
lgtm once FYI builder passes. https://codereview.chromium.org/126453006/diff/1/build/android/lint/suppressions.xml File build/android/lint/suppressions.xml (right): https://codereview.chromium.org/126453006/diff/1/build/android/lint/suppressions.xml#newcode130 build/android/lint/suppressions.xml:130: <ignore path="android_webview/java/src/org/chromium/android_webview/AwQuotaManagerBridge.java"/> You can ...
6 years, 11 months ago (2014-01-08 20:50:17 UTC) #2
boliu
Failed build (in PS1) due to some suppressions I removed: http://build.chromium.org/p/tryserver.chromium/builders/android_fyi_dbg/builds/3414/steps/compile/logs/stdio But I didn't get ...
6 years, 11 months ago (2014-01-08 21:41:31 UTC) #3
boliu
On 2014/01/08 21:41:31, boliu wrote: > Failed build (in PS1) due to some suppressions I ...
6 years, 11 months ago (2014-01-08 21:54:53 UTC) #4
boliu
ptal
6 years, 11 months ago (2014-01-08 22:17:23 UTC) #5
frankf
still lgtm https://codereview.chromium.org/126453006/diff/160001/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java File android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java (right): https://codereview.chromium.org/126453006/diff/160001/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java#newcode124 android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java:124: assertEquals(refNamesAndValues[i].toLowerCase(Locale.ENGLISH), header.getName()); I prefer Locale.US but ok ...
6 years, 11 months ago (2014-01-08 22:35:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/126453006/160001
6 years, 11 months ago (2014-01-09 00:02:27 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 05:08:27 UTC) #8
Message was sent while issue was closed. 
Change committed as 243781

Powered by Google App Engine
This is Rietveld 408576698