Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <lint> | 2 <lint> |
| 3 <!-- | 3 <!-- |
| 4 STOP! It looks like you want to suppress some lint errors: | 4 STOP! It looks like you want to suppress some lint errors: |
| 5 - Have you tried identifing the offending patch? | 5 - Have you tried identifing the offending patch? |
| 6 Ask the author for a fix and/or revert the patch. | 6 Ask the author for a fix and/or revert the patch. |
| 7 - It is preferred to add suppressions in the code instead of | 7 - It is preferred to add suppressions in the code instead of |
| 8 sweeping it under the rug here. See: | 8 sweeping it under the rug here. See: |
| 9 | 9 |
| 10 http://developer.android.com/tools/debugging/improving-w-lint.html | 10 http://developer.android.com/tools/debugging/improving-w-lint.html |
| (...skipping 11 matching lines...) Expand all Loading... | |
| 22 directory path (e.g. out/Debug) | 22 directory path (e.g. out/Debug) |
| 23 --> | 23 --> |
| 24 <issue id="AllowBackup"> | 24 <issue id="AllowBackup"> |
| 25 <ignore path="AndroidManifest.xml"/> | 25 <ignore path="AndroidManifest.xml"/> |
| 26 </issue> | 26 </issue> |
| 27 <issue id="CommitPrefEdits"> | 27 <issue id="CommitPrefEdits"> |
| 28 <ignore path="third_party/cacheinvalidation/src/java/com/google/ipc/invalida tion/ticl/android2/channel/AndroidChannelPreferences.java"/> | 28 <ignore path="third_party/cacheinvalidation/src/java/com/google/ipc/invalida tion/ticl/android2/channel/AndroidChannelPreferences.java"/> |
| 29 </issue> | 29 </issue> |
| 30 <issue id="DefaultLocale"> | 30 <issue id="DefaultLocale"> |
| 31 <ignore path="PRODUCT_DIR/content_shell_test_apk/classes/org/chromium/conten t/browser/ViewportTest.class"/> | 31 <ignore path="PRODUCT_DIR/content_shell_test_apk/classes/org/chromium/conten t/browser/ViewportTest.class"/> |
| 32 <ignore path="android_webview/javatests/src/org/chromium/android_webview/tes t/AwViewportTest.java"/> | |
| 33 <ignore path="android_webview/javatests/src/org/chromium/android_webview/tes t/LoadUrlTest.java"/> | |
| 34 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/net/spdypr oxy/DataReductionProxySettings.java"/> | 32 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/net/spdypr oxy/DataReductionProxySettings.java"/> |
| 35 <ignore path="chrome/android/testshell/javatests/src/org/chromium/chrome/tes tshell/ChromiumTestShellUrlTest.java"/> | 33 <ignore path="chrome/android/testshell/javatests/src/org/chromium/chrome/tes tshell/ChromiumTestShellUrlTest.java"/> |
| 36 <ignore path="chrome/test/android/javatests/src/org/chromium/chrome/test/uti l/browser/sync/SyncTestUtil.java"/> | 34 <ignore path="chrome/test/android/javatests/src/org/chromium/chrome/test/uti l/browser/sync/SyncTestUtil.java"/> |
| 37 <ignore path="content/public/android/java/src/org/chromium/content/app/Linke r.java"/> | 35 <ignore path="content/public/android/java/src/org/chromium/content/app/Linke r.java"/> |
| 38 <ignore path="content/public/android/java/src/org/chromium/content/browser/L oadUrlParams.java"/> | 36 <ignore path="content/public/android/java/src/org/chromium/content/browser/L oadUrlParams.java"/> |
| 39 <ignore path="content/public/android/java/src/org/chromium/content/browser/a ccessibility/JellyBeanAccessibilityInjector.java"/> | 37 <ignore path="content/public/android/java/src/org/chromium/content/browser/a ccessibility/JellyBeanAccessibilityInjector.java"/> |
| 40 <ignore path="content/public/android/javatests/src/org/chromium/content/brow ser/ViewportTest.java"/> | 38 <ignore path="content/public/android/javatests/src/org/chromium/content/brow ser/ViewportTest.java"/> |
| 41 <ignore path="third_party/cacheinvalidation/src/java/com/google/ipc/invalida tion/external/client/contrib/AndroidListenerState.java"/> | 39 <ignore path="third_party/cacheinvalidation/src/java/com/google/ipc/invalida tion/external/client/contrib/AndroidListenerState.java"/> |
| 42 </issue> | 40 </issue> |
| 43 <issue id="DrawAllocation"> | 41 <issue id="DrawAllocation"> |
| (...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 112 <ignore path="ui/android/java/src/org/chromium/ui/ColorPickerAdvancedCompone nt.java"/> | 110 <ignore path="ui/android/java/src/org/chromium/ui/ColorPickerAdvancedCompone nt.java"/> |
| 113 <ignore path="ui/android/java/src/org/chromium/ui/base/Clipboard.java"/> | 111 <ignore path="ui/android/java/src/org/chromium/ui/base/Clipboard.java"/> |
| 114 <ignore path="ui/android/java/src/org/chromium/ui/base/LocalizationUtils.jav a"/> | 112 <ignore path="ui/android/java/src/org/chromium/ui/base/LocalizationUtils.jav a"/> |
| 115 <ignore path="ui/android/java/src/org/chromium/ui/gl/SurfaceTexturePlatformW rapper.java"/> | 113 <ignore path="ui/android/java/src/org/chromium/ui/gl/SurfaceTexturePlatformW rapper.java"/> |
| 116 </issue> | 114 </issue> |
| 117 <issue id="OldTargetApi"> | 115 <issue id="OldTargetApi"> |
| 118 <ignore path="AndroidManifest.xml"/> | 116 <ignore path="AndroidManifest.xml"/> |
| 119 </issue> | 117 </issue> |
| 120 <issue id="Recycle" severity="Error"> | 118 <issue id="Recycle" severity="Error"> |
| 121 <ignore path="PRODUCT_DIR/content_shell_test_apk/classes/org/chromium/conten t/browser/ContentViewGestureHandlerTest.class"/> | 119 <ignore path="PRODUCT_DIR/content_shell_test_apk/classes/org/chromium/conten t/browser/ContentViewGestureHandlerTest.class"/> |
| 122 <ignore path="android_webview/javatests/src/org/chromium/android_webview/tes t/WebKitHitTestTest.java"/> | |
| 123 <ignore path="android_webview/javatests/src/org/chromium/android_webview/tes t/util/AwTestTouchUtils.java"/> | |
| 124 <ignore path="chrome/android/javatests/src/org/chromium/chrome/browser/test/ ProviderBookmarkNodeTest.java"/> | 120 <ignore path="chrome/android/javatests/src/org/chromium/chrome/browser/test/ ProviderBookmarkNodeTest.java"/> |
| 125 <ignore path="content/public/test/android/javatests/src/org/chromium/content /browser/test/util/TestTouchUtils.java"/> | 121 <ignore path="content/public/test/android/javatests/src/org/chromium/content /browser/test/util/TestTouchUtils.java"/> |
| 126 <ignore path="content/public/test/android/javatests/src/org/chromium/content /browser/test/util/TouchCommon.java"/> | 122 <ignore path="content/public/test/android/javatests/src/org/chromium/content /browser/test/util/TouchCommon.java"/> |
| 127 </issue> | 123 </issue> |
| 128 <issue id="Registered" severity="ignore"/> | 124 <issue id="Registered" severity="ignore"/> |
| 129 <issue id="SdCardPath"> | 125 <issue id="SdCardPath"> |
| 130 <ignore path="content/public/android/java/src/org/chromium/content/browser/M ediaResourceGetter.java"/> | 126 <ignore path="content/public/android/java/src/org/chromium/content/browser/M ediaResourceGetter.java"/> |
| 131 </issue> | 127 </issue> |
| 132 <issue id="SetJavaScriptEnabled" severity="ignore"/> | 128 <issue id="SetJavaScriptEnabled" severity="ignore"/> |
| 133 <issue id="UseSparseArrays"> | 129 <issue id="UseSparseArrays"> |
| 134 <ignore path="android_webview/java/src/org/chromium/android_webview/AwQuotaM anagerBridge.java"/> | 130 <ignore path="android_webview/java/src/org/chromium/android_webview/AwQuotaM anagerBridge.java"/> |
|
frankf
2014/01/08 20:50:17
You can remove this now
| |
| 135 <ignore path="android_webview/java/src/org/chromium/android_webview/AwResour ce.java"/> | 131 <ignore path="android_webview/java/src/org/chromium/android_webview/AwResour ce.java"/> |
| 136 <ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDe tector.java"/> | 132 <ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDe tector.java"/> |
| 137 <ignore path="ui/android/java/src/org/chromium/ui/base/WindowAndroid.java"/> | 133 <ignore path="ui/android/java/src/org/chromium/ui/base/WindowAndroid.java"/> |
| 138 </issue> | 134 </issue> |
| 139 <issue id="ViewConstructor" severity="ignore"/> | 135 <issue id="ViewConstructor" severity="ignore"/> |
| 140 <issue id="WrongCall" severity="ignore"/> | 136 <issue id="WrongCall" severity="ignore"/> |
| 141 </lint> | 137 </lint> |
| OLD | NEW |