Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java

Issue 126453006: aw: Clean up android webview lint suppressions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove .class from suppression Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java
index 71649cb5a887e087ce3093857309d066a10caf21..4a6bab55c7560e251fd9b143673134be9e0e3761 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java
@@ -22,6 +22,7 @@ import org.chromium.net.test.util.TestWebServer;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
+import java.util.Locale;
import java.util.Map;
import java.util.concurrent.TimeUnit;
@@ -120,7 +121,7 @@ public class LoadUrlTest extends AwTestBase {
assertEquals(1, matchingHeaders.length);
Header header = matchingHeaders[0];
- assertEquals(refNamesAndValues[i].toLowerCase(), header.getName());
+ assertEquals(refNamesAndValues[i].toLowerCase(Locale.ENGLISH), header.getName());
frankf 2014/01/08 22:35:49 I prefer Locale.US but ok :)
assertEquals(refNamesAndValues[i + 1], header.getValue());
}
}
@@ -196,7 +197,8 @@ public class LoadUrlTest extends AwTestBase {
Header[] matchingHeaders = webServer.getLastRequest(path).getHeaders(extraHeaders[0]);
assertEquals(1, matchingHeaders.length);
Header header = matchingHeaders[0];
- assertEquals(extraHeaders[0].toLowerCase(), header.getName().toLowerCase());
+ assertEquals(extraHeaders[0].toLowerCase(Locale.ENGLISH),
+ header.getName().toLowerCase(Locale.ENGLISH));
// Just check that the value is there, and it's not the one we provided.
assertTrue(header.getValue().length() > 0);
assertFalse(extraHeaders[1].equals(header.getValue()));

Powered by Google App Engine
This is Rietveld 408576698