Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1264003002: SRGB read and write pixels working and unit test (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 4 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SRGB read and write pixels working and unit test Committed: https://skia.googlesource.com/skia/+/16921ec30a81976129d507b1148c93a322e61a4f

Patch Set 1 #

Patch Set 2 : comment changes #

Patch Set 3 : update #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -43 lines) Patch
M include/gpu/GrCaps.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/GrTypes.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 4 chunks +10 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 8 chunks +32 lines, -27 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 3 8 chunks +50 lines, -9 lines 0 comments Download
A tests/SRGBReadWritePixelsTest.cpp View 1 2 1 chunk +235 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
bsalomon
5 years, 4 months ago (2015-07-30 17:05:14 UTC) #2
jvanverth1
lgtm
5 years, 4 months ago (2015-07-30 18:29:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264003002/20001
5 years, 4 months ago (2015-07-30 18:46:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/2361)
5 years, 4 months ago (2015-07-30 18:48:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264003002/40001
5 years, 4 months ago (2015-07-30 22:08:34 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/2271) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 4 months ago (2015-07-30 22:09:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264003002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264003002/60001
5 years, 4 months ago (2015-07-30 22:27:11 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 22:35:01 UTC) #16
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/16921ec30a81976129d507b1148c93a322e61a4f

Powered by Google App Engine
This is Rietveld 408576698