Issue 1263963002: Merge to XFA: Plumb in an externally created v8::Isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1263963002: Merge to XFA: Plumb in an externally created v8::Isolate (Closed)

Created:
5 years, 4 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 4 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -24 lines)			Patch
M	fpdfsdk/include/jsapi/fxjs_v8.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/javascript/JS_Runtime.cpp	View	2 chunks	+14 lines, -4 lines	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View	14 chunks	+19 lines, -14 lines	0 comments	Download
M	public/fpdf_formfill.h	View	2 chunks	+19 lines, -3 lines	0 comments	Download
M	samples/pdfium_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	testing/embedder_test.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

jochen (gone - plz use gerrit)

5 years, 4 months ago (2015-07-30 15:44:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
06b60021edacf7e4f2d1b1468a3aa898bab10301 (presubmit successful).