Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1235303003: Make v8 embedder data slot configurable (Closed)

Created:
5 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 5 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make v8 embedder data slot configurable Chrome already uses 0 and 1. BUG=none R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/cc8b4d8763151f51c9fe71ce9b64b2a0d7ddcc88

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -17 lines) Patch
M fpdfsdk/include/jsapi/fxjs_v8.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 14 chunks +17 lines, -15 lines 0 comments Download
M public/fpdf_formfill.h View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
5 years, 5 months ago (2015-07-15 19:34:57 UTC) #1
Tom Sepez
LGTM % nit https://codereview.chromium.org/1235303003/diff/1/public/fpdf_formfill.h File public/fpdf_formfill.h (right): https://codereview.chromium.org/1235303003/diff/1/public/fpdf_formfill.h#newcode236 public/fpdf_formfill.h:236: * The embedder data slot to ...
5 years, 5 months ago (2015-07-15 22:27:57 UTC) #2
jochen (gone - plz use gerrit)
5 years, 5 months ago (2015-07-16 07:37:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cc8b4d8763151f51c9fe71ce9b64b2a0d7ddcc88 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698