Merge to XFA: Plumb in an externally created v8::Isolate

fpdfsdk/src/jsapi/fxjs_v8.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../core/include/fxcrt/fx_basic.h"
 #include "../../../core/include/fxcrt/fx_ext.h"
 #include "../../include/jsapi/fxjs_v8.h"
 #include "../../include/fsdk_define.h"
 #include "time.h"
 #include <cmath>
 #include <limits>
 
 #define VALUE_NAME_STRING               L"string"
 #define VALUE_NAME_NUMBER               L"number"
 #define VALUE_NAME_BOOLEAN              L"boolean"
 #define VALUE_NAME_DATE                 L"date"
 #define VALUE_NAME_OBJECT               L"object"
 #define VALUE_NAME_FXOBJ                L"fxobj"
 #define VALUE_NAME_NULL                 L"null"
 #define VALUE_NAME_UNDEFINED    L"undefined"
 
 const static FX_DWORD g_nan[2] = {0,0x7FF80000 };
 static double GetNan()
 {
   return *(double*)g_nan;
 }
+static unsigned int g_embedderDataSlot = 0u;
 
 
 class CJS_PrivateData
 {
 public:
         CJS_PrivateData():ObjDefID(-1), pPrivate(NULL) {}
         int ObjDefID;
         void*   pPrivate;
 };
 
@@ skipping 32 matching lines @@
 
         v8::Global<v8::ObjectTemplate> m_objTemplate;
         v8::Global<v8::Object> m_StaticObj;
 };
 
 int JS_DefineObj(IJS_Runtime* pJSRuntime, const wchar_t* sObjName, FXJSOBJTYPE eObjType, LP_CONSTRUCTOR pConstructor, LP_DESTRUCTOR pDestructor)
 {
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
         v8::HandleScope handle_scope(isolate);
-        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(1);
+        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(g_embedderDataSlot);
         if(!pArray)
         {
                 pArray = FX_NEW CFX_PtrArray();
-                isolate->SetData(1, pArray);
+                isolate->SetData(g_embedderDataSlot, pArray);
         }
         CJS_ObjDefintion* pObjDef = FX_NEW CJS_ObjDefintion(isolate, sObjName, eObjType, pConstructor, pDestructor);
         pArray->Add(pObjDef);
         return pArray->GetSize()-1;
 }
 
 int JS_DefineObjMethod(IJS_Runtime* pJSRuntime, int nObjDefnID, const wchar_t* sMethodName, v8::FunctionCallback pMethodCall)
 {
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
         v8::HandleScope handle_scope(isolate);
 
         CFX_WideString ws = CFX_WideString(sMethodName);
         CFX_ByteString bsMethodName = ws.UTF8Encode();
 
-        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(1);
+        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(g_embedderDataSlot);
         if(!pArray) return 0;
 
         if(nObjDefnID<0 || nObjDefnID>= pArray->GetSize()) return 0;
         CJS_ObjDefintion* pObjDef = (CJS_ObjDefintion*)pArray->GetAt(nObjDefnID);
         v8::Local<v8::ObjectTemplate> objTemp = v8::Local<v8::ObjectTemplate>::New(isolate, pObjDef->m_objTemplate);
         objTemp->Set(v8::String::NewFromUtf8(isolate, bsMethodName.c_str(), v8::NewStringType::kNormal).ToLocalChecked(), v8::FunctionTemplate::New(isolate, pMethodCall), v8::ReadOnly);
         pObjDef->m_objTemplate.Reset(isolate,objTemp);
         return 0;
 }
 
 int JS_DefineObjProperty(IJS_Runtime* pJSRuntime, int nObjDefnID, const wchar_t* sPropName, v8::AccessorGetterCallback pPropGet, v8::AccessorSetterCallback pPropPut)
 {
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
         v8::HandleScope handle_scope(isolate);
 
         CFX_WideString ws = CFX_WideString(sPropName);
         CFX_ByteString bsPropertyName = ws.UTF8Encode();
 
-        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(1);
+        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(g_embedderDataSlot);
         if(!pArray) return 0;
 
         if(nObjDefnID<0 || nObjDefnID>= pArray->GetSize()) return 0;
         CJS_ObjDefintion* pObjDef = (CJS_ObjDefintion*)pArray->GetAt(nObjDefnID);
         v8::Local<v8::ObjectTemplate> objTemp = v8::Local<v8::ObjectTemplate>::New(isolate, pObjDef->m_objTemplate);
         objTemp->SetAccessor(v8::String::NewFromUtf8(isolate, bsPropertyName.c_str(), v8::NewStringType::kNormal).ToLocalChecked(), pPropGet, pPropPut);
         pObjDef->m_objTemplate.Reset(isolate,objTemp);
         return 0;
 }
 
 int     JS_DefineObjAllProperties(IJS_Runtime* pJSRuntime, int nObjDefnID, v8::NamedPropertyQueryCallback pPropQurey, v8::NamedPropertyGetterCallback pPropGet, v8::NamedPropertySetterCallback pPropPut, v8::NamedPropertyDeleterCallback pPropDel)
 {
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
         v8::HandleScope handle_scope(isolate);
 
-        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(1);
+        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(g_embedderDataSlot);
         if(!pArray) return 0;
 
         if(nObjDefnID<0 || nObjDefnID>= pArray->GetSize()) return 0;
         CJS_ObjDefintion* pObjDef = (CJS_ObjDefintion*)pArray->GetAt(nObjDefnID);
         v8::Local<v8::ObjectTemplate> objTemp = v8::Local<v8::ObjectTemplate>::New(isolate, pObjDef->m_objTemplate);
         objTemp->SetNamedPropertyHandler(pPropGet, pPropPut, pPropQurey, pPropDel);
         pObjDef->m_objTemplate.Reset(isolate,objTemp);
         return 0;
 }
 
 int JS_DefineObjConst(IJS_Runtime* pJSRuntime, int nObjDefnID, const wchar_t* sConstName, v8::Local<v8::Value> pDefault)
 {
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
         v8::HandleScope handle_scope(isolate);
 
-        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(1);
+        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(g_embedderDataSlot);
         if(!pArray) return 0;
 
         CFX_WideString ws = CFX_WideString(sConstName);
         CFX_ByteString bsConstName = ws.UTF8Encode();
 
         if(nObjDefnID<0 || nObjDefnID>= pArray->GetSize()) return 0;
         CJS_ObjDefintion* pObjDef = (CJS_ObjDefintion*)pArray->GetAt(nObjDefnID);
         v8::Local<v8::ObjectTemplate> objTemp = v8::Local<v8::ObjectTemplate>::New(isolate, pObjDef->m_objTemplate);
         objTemp->Set(isolate, bsConstName.c_str(), pDefault);
         pObjDef->m_objTemplate.Reset(isolate,objTemp);
         return 0;
 }
 
 static v8::Global<v8::ObjectTemplate>& _getGlobalObjectTemplate(IJS_Runtime* pJSRuntime)
 {
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
         v8::HandleScope handle_scope(isolate);
 
-        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(1);
+        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(g_embedderDataSlot);
         ASSERT(pArray != NULL);
         for(int i=0; i<pArray->GetSize(); i++)
         {
                 CJS_ObjDefintion* pObjDef = (CJS_ObjDefintion*)pArray->GetAt(i);
                 if(pObjDef->m_bSetAsGlobalObject)
                         return pObjDef->m_objTemplate;
         }
         static v8::Global<v8::ObjectTemplate> gloabalObjectTemplate;
         return gloabalObjectTemplate;
 }
@@ skipping 52 matching lines @@
         v8::Isolate::Scope isolate_scope(isolate);
         v8::Locker locker(isolate);
         v8::HandleScope handle_scope(isolate);
 
         v8::Global<v8::ObjectTemplate>& globalObjTemp = _getGlobalObjectTemplate(pJSRuntime);
         v8::Local<v8::Context> v8Context = v8::Context::New(isolate, NULL, v8::Local<v8::ObjectTemplate>::New(isolate, globalObjTemp));
         v8::Context::Scope context_scope(v8Context);
 
         //v8::Local<External> ptr = External::New(isolate, pFXRuntime);
         //v8Context->SetEmbedderData(1, ptr);
+        // TODO(tsepez): Don't use more than one embedder data slot.
         isolate->SetData(2, pFXRuntime);
 
-        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(1);
+        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(g_embedderDataSlot);
         if(!pArray) return;
 
         for(int i=0; i<pArray->GetSize(); i++)
         {
                 CJS_ObjDefintion* pObjDef = (CJS_ObjDefintion*)pArray->GetAt(i);
                 CFX_WideString ws = CFX_WideString(pObjDef->objName);
                 CFX_ByteString bs = ws.UTF8Encode();
                 v8::Local<v8::String> objName = v8::String::NewFromUtf8(isolate, bs.c_str(), v8::NewStringType::kNormal, bs.GetLength()).ToLocalChecked();
 
 
@@ skipping 23 matching lines @@
         v8PersistentContext.Reset(isolate, v8Context);
 }
 
 void JS_ReleaseRuntime(IJS_Runtime* pJSRuntime, v8::Global<v8::Context>& v8PersistentContext)
 {
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
         v8::Locker locker(isolate);
         v8::HandleScope handle_scope(isolate);
 
-        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(1);
+        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(g_embedderDataSlot);
         if(!pArray) return ;
 
         for(int i=0; i<pArray->GetSize(); i++)
         {
                 CJS_ObjDefintion* pObjDef = (CJS_ObjDefintion*)pArray->GetAt(i);
                 if(!pObjDef->m_StaticObj.IsEmpty())
                 {
                         v8::Local<v8::Object> pObj = v8::Local<v8::Object>::New(isolate, pObjDef->m_StaticObj);
                         if(pObjDef->m_pDestructor)
                                 pObjDef->m_pDestructor(pObj);
                         JS_FreePrivate(pObj);
                 }
                 delete pObjDef;
         }
         delete pArray;
         isolate->SetData(1,NULL);
+        isolate->SetData(g_embedderDataSlot,NULL);
+        // TODO(tsepez): Don't use more than one embedder data slot.
         isolate->SetData(2,NULL);
 }
 
-void JS_Initial()
+void JS_Initial(unsigned int embedderDataSlot)
 {
+        g_embedderDataSlot = embedderDataSlot;
 }
 void JS_Release()
 {
 
 }
 int JS_Parse(IJS_Runtime* pJSRuntime, IFXJS_Context* pJSContext, const wchar_t* script, long length, FXJSErr* perror)
 {
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
         v8::TryCatch try_catch(isolate);
@@ skipping 41 matching lines @@
         v8::Isolate::Scope isolate_scope(isolate);
         v8::Local<v8::Context> context = isolate->GetCurrentContext();
         if(-1 == nObjDefnID)
         {
                 v8::Local<v8::ObjectTemplate> objTempl = v8::ObjectTemplate::New(isolate);
                 v8::Local<v8::Object> obj;
                 if (objTempl->NewInstance(context).ToLocal(&obj)) return obj;
                 return v8::Local<v8::Object>();
         }
 
-        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(1);
+        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(g_embedderDataSlot);
         if(!pArray) return v8::Local<v8::Object>();
 
 
         if(nObjDefnID<0 || nObjDefnID>= pArray->GetSize()) return v8::Local<v8::Object>();
         CJS_ObjDefintion* pObjDef = (CJS_ObjDefintion*)pArray->GetAt(nObjDefnID);
 
         v8::Local<v8::ObjectTemplate> objTemp = v8::Local<v8::ObjectTemplate>::New(isolate, pObjDef->m_objTemplate);
         v8::Local<v8::Object> obj;
         if (!objTemp->NewInstance(context).ToLocal(&obj)) return v8::Local<v8::Object>();
         CJS_PrivateData* pPrivateData = FX_NEW CJS_PrivateData;
         pPrivateData->ObjDefID = nObjDefnID;
 
         obj->SetAlignedPointerInInternalField(0, pPrivateData);
         if(pObjDef->m_pConstructor)
                 pObjDef->m_pConstructor(pJSContext, obj, context->Global()->GetPrototype()->ToObject(context).ToLocalChecked());
 
         return obj;
 }
 
 v8::Local<v8::Object> JS_GetStaticObj(IJS_Runtime* pJSRuntime, int nObjDefnID)
 {
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
 
-        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(1);
+        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(g_embedderDataSlot);
         if(!pArray) return v8::Local<v8::Object>();
 
         if(nObjDefnID<0 || nObjDefnID>= pArray->GetSize()) return v8::Local<v8::Object>();
         CJS_ObjDefintion* pObjDef = (CJS_ObjDefintion*)pArray->GetAt(nObjDefnID);
         v8::Local<v8::Object> obj = v8::Local<v8::Object>::New(isolate,pObjDef->m_StaticObj);
         return obj;
 }
 
 void JS_SetThisObj(IJS_Runtime* pJSRuntime, int nThisObjID)
 {
         //Do nothing.
 }
 v8::Local<v8::Object>   JS_GetThisObj(IJS_Runtime * pJSRuntime)
 {
         //Return the global object.
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
 
-        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(1);
+        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(g_embedderDataSlot);
         if(!pArray) return v8::Local<v8::Object>();
 
         v8::Local<v8::Context> context = isolate->GetCurrentContext();
         return context->Global()->GetPrototype()->ToObject(context).ToLocalChecked();
 }
 
 int     JS_GetObjDefnID(v8::Local<v8::Object> pObj)
 {
         if(pObj.IsEmpty() || !pObj->InternalFieldCount()) return -1;
         CJS_PrivateData* pPrivateData = (CJS_PrivateData*)pObj->GetAlignedPointerFromInternalField(0);
         if(pPrivateData)
                 return pPrivateData->ObjDefID;
         return -1;
 }
 
 IJS_Runtime* JS_GetRuntime(v8::Local<v8::Object> pObj)
 {
         if(pObj.IsEmpty()) return NULL;
         v8::Local<v8::Context> context = pObj->CreationContext();
         if(context.IsEmpty()) return NULL;
         return context->GetIsolate();
 }
 
 int JS_GetObjDefnID(IJS_Runtime * pJSRuntime, const wchar_t* pObjName)
 {
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
 
-        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(1);
+        CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(g_embedderDataSlot);
         if(!pArray) return -1;
 
         for(int i=0; i<pArray->GetSize(); i++)
         {
                 CJS_ObjDefintion* pObjDef = (CJS_ObjDefintion*)pArray->GetAt(i);
                 if(FXSYS_wcscmp(pObjDef->objName, pObjName) == 0)
                         return i;
         }
         return -1;
 }
@@ skipping 600 matching lines @@
 {
         return d != d;
 }
 
 double JS_LocalTime(double d)
 {
         return JS_GetDateTime() + _getDaylightSavingTA(d);
 }
 
 //JavaScript time implement End.