Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1263923002: Revert of Refactor the treatment of shape-outside objects in float overlapping checks (Closed)

Created:
5 years, 4 months ago by dtu
Modified:
5 years, 3 months ago
Reviewers:
rhogan, Xianzhu, wangxianzhu
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Refactor the treatment of shape-outside objects in float overlapping checks (patchset #1 id:1 of https://codereview.chromium.org/1242253002/) Reason for revert: We're seeing timeouts on The Android perf bots: https://crbug.com/514790#c24 Original issue's description: > Refactor the treatment of shape-outside objects in float overlapping checks > > Integrate shape-outside into the red-black tree used for checking whether an > object overlaps with a float. > > This merges WebKit CL http://trac.webkit.org/changeset/158954 > > BUG=510872 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199519 TBR=wangxianzhu@google.com,wangxianzhu@chromium.org,robhogan@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510872 Committed: https://crrev.com/b62dc5eafc96145f3169c2071cf64be2da73f61e git-svn-id: svn://svn.chromium.org/blink/trunk@199689 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -113 lines) Patch
M Source/core/layout/FloatingObjects.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/layout/FloatingObjects.cpp View 8 chunks +29 lines, -95 lines 0 comments Download
M Source/core/layout/LayoutBlockFlow.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/layout/LayoutBlockFlow.cpp View 2 chunks +21 lines, -11 lines 0 comments Download
M Source/core/layout/api/LineLayoutBlockFlow.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/line/LineWidth.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dtu
Created Revert of Refactor the treatment of shape-outside objects in float overlapping checks
5 years, 4 months ago (2015-07-30 00:06:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263923002/1
5 years, 4 months ago (2015-07-30 00:07:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199689
5 years, 4 months ago (2015-07-30 00:08:22 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:54:36 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b62dc5eafc96145f3169c2071cf64be2da73f61e

Powered by Google App Engine
This is Rietveld 408576698