Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: Source/core/layout/FloatingObjects.h

Issue 1263923002: Revert of Refactor the treatment of shape-outside objects in float overlapping checks (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/layout/FloatingObjects.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 17 matching lines...) Expand all
28 #include "platform/PODFreeListArena.h" 28 #include "platform/PODFreeListArena.h"
29 #include "platform/PODIntervalTree.h" 29 #include "platform/PODIntervalTree.h"
30 #include "wtf/ListHashSet.h" 30 #include "wtf/ListHashSet.h"
31 #include "wtf/OwnPtr.h" 31 #include "wtf/OwnPtr.h"
32 32
33 namespace blink { 33 namespace blink {
34 34
35 class LayoutBlockFlow; 35 class LayoutBlockFlow;
36 class LayoutBox; 36 class LayoutBox;
37 37
38 // FIXME this should be removed once LayoutBlockFlow::nextFloatLogicalBottomBelo w doesn't need it anymore. (Bug 123931)
39 enum ShapeOutsideFloatOffsetMode { ShapeOutsideFloatShapeOffset, ShapeOutsideFlo atMarginBoxOffset };
40
38 class FloatingObject { 41 class FloatingObject {
39 WTF_MAKE_NONCOPYABLE(FloatingObject); WTF_MAKE_FAST_ALLOCATED(FloatingObject ); 42 WTF_MAKE_NONCOPYABLE(FloatingObject); WTF_MAKE_FAST_ALLOCATED(FloatingObject );
40 public: 43 public:
41 #ifndef NDEBUG 44 #ifndef NDEBUG
42 // Used by the PODIntervalTree for debugging the FloatingObject. 45 // Used by the PODIntervalTree for debugging the FloatingObject.
43 template <class> friend struct ValueToString; 46 template <class> friend struct ValueToString;
44 #endif 47 #endif
45 48
46 // Note that Type uses bits so you can use FloatLeftRight as a mask to query for both left and right. 49 // Note that Type uses bits so you can use FloatLeftRight as a mask to query for both left and right.
47 enum Type { FloatLeft = 1, FloatRight = 2, FloatLeftRight = 3 }; 50 enum Type { FloatLeft = 1, FloatRight = 2, FloatLeftRight = 3 };
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 bool hasLeftObjects() const { return m_leftObjectsCount > 0; } 152 bool hasLeftObjects() const { return m_leftObjectsCount > 0; }
150 bool hasRightObjects() const { return m_rightObjectsCount > 0; } 153 bool hasRightObjects() const { return m_rightObjectsCount > 0; }
151 const FloatingObjectSet& set() const { return m_set; } 154 const FloatingObjectSet& set() const { return m_set; }
152 void clearLineBoxTreePointers(); 155 void clearLineBoxTreePointers();
153 156
154 LayoutUnit logicalLeftOffset(LayoutUnit fixedOffset, LayoutUnit logicalTop, LayoutUnit logicalHeight); 157 LayoutUnit logicalLeftOffset(LayoutUnit fixedOffset, LayoutUnit logicalTop, LayoutUnit logicalHeight);
155 LayoutUnit logicalRightOffset(LayoutUnit fixedOffset, LayoutUnit logicalTop, LayoutUnit logicalHeight); 158 LayoutUnit logicalRightOffset(LayoutUnit fixedOffset, LayoutUnit logicalTop, LayoutUnit logicalHeight);
156 159
157 LayoutUnit logicalLeftOffsetForPositioningFloat(LayoutUnit fixedOffset, Layo utUnit logicalTop, LayoutUnit* heightRemaining); 160 LayoutUnit logicalLeftOffsetForPositioningFloat(LayoutUnit fixedOffset, Layo utUnit logicalTop, LayoutUnit* heightRemaining);
158 LayoutUnit logicalRightOffsetForPositioningFloat(LayoutUnit fixedOffset, Lay outUnit logicalTop, LayoutUnit* heightRemaining); 161 LayoutUnit logicalRightOffsetForPositioningFloat(LayoutUnit fixedOffset, Lay outUnit logicalTop, LayoutUnit* heightRemaining);
159 LayoutUnit findNextFloatLogicalBottomBelow(LayoutUnit logicalHeight);
160 LayoutUnit findNextFloatLogicalBottomBelowForBlock(LayoutUnit logicalHeight) ;
161 162
162 LayoutUnit lowestFloatLogicalBottom(FloatingObject::Type); 163 LayoutUnit lowestFloatLogicalBottom(FloatingObject::Type);
163 FloatingObject* lowestFloatingObject() const; 164 FloatingObject* lowestFloatingObject() const;
164 165
165 private: 166 private:
166 bool hasLowestFloatLogicalBottomCached(bool isHorizontal, FloatingObject::Ty pe floatType) const; 167 bool hasLowestFloatLogicalBottomCached(bool isHorizontal, FloatingObject::Ty pe floatType) const;
167 LayoutUnit getCachedlowestFloatLogicalBottom(FloatingObject::Type floatType) const; 168 LayoutUnit getCachedlowestFloatLogicalBottom(FloatingObject::Type floatType) const;
168 void setCachedLowestFloatLogicalBottom(bool isHorizontal, FloatingObject::Ty pe floatType, FloatingObject*); 169 void setCachedLowestFloatLogicalBottom(bool isHorizontal, FloatingObject::Ty pe floatType, FloatingObject*);
169 void markLowestFloatLogicalBottomCacheAsDirty(); 170 void markLowestFloatLogicalBottomCacheAsDirty();
170 171
(...skipping 30 matching lines...) Expand all
201 static String string(const int value); 202 static String string(const int value);
202 }; 203 };
203 template<> struct ValueToString<FloatingObject*> { 204 template<> struct ValueToString<FloatingObject*> {
204 static String string(const FloatingObject*); 205 static String string(const FloatingObject*);
205 }; 206 };
206 #endif 207 #endif
207 208
208 } // namespace blink 209 } // namespace blink
209 210
210 #endif // FloatingObjects_h 211 #endif // FloatingObjects_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/layout/FloatingObjects.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698