Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: Source/core/layout/LayoutBlockFlow.h

Issue 1263923002: Revert of Refactor the treatment of shape-outside objects in float overlapping checks (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/layout/FloatingObjects.cpp ('k') | Source/core/layout/LayoutBlockFlow.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003-2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2003-2013 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * Copyright (C) 2013 Google Inc. All rights reserved. 7 * Copyright (C) 2013 Google Inc. All rights reserved.
8 * 8 *
9 * Redistribution and use in source and binary forms, with or without 9 * Redistribution and use in source and binary forms, with or without
10 * modification, are permitted provided that the following conditions are 10 * modification, are permitted provided that the following conditions are
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 const char* name() const override { return "LayoutBlockFlow"; } 240 const char* name() const override { return "LayoutBlockFlow"; }
241 241
242 FloatingObject* insertFloatingObject(LayoutBox&); 242 FloatingObject* insertFloatingObject(LayoutBox&);
243 243
244 // Called from lineWidth, to position the floats added in the last line. 244 // Called from lineWidth, to position the floats added in the last line.
245 // Returns true if and only if it has positioned any floats. 245 // Returns true if and only if it has positioned any floats.
246 bool positionNewFloats(LineWidth* = nullptr); 246 bool positionNewFloats(LineWidth* = nullptr);
247 247
248 bool positionNewFloatOnLine(FloatingObject& newFloat, FloatingObject* lastFl oatFromPreviousLine, LineInfo&, LineWidth&); 248 bool positionNewFloatOnLine(FloatingObject& newFloat, FloatingObject* lastFl oatFromPreviousLine, LineInfo&, LineWidth&);
249 249
250 LayoutUnit nextFloatLogicalBottomBelow(LayoutUnit) const; 250 LayoutUnit nextFloatLogicalBottomBelow(LayoutUnit, ShapeOutsideFloatOffsetMo de = ShapeOutsideFloatMarginBoxOffset) const;
251 LayoutUnit nextFloatLogicalBottomBelowForBlock(LayoutUnit) const;
252 251
253 FloatingObject* lastFloatFromPreviousLine() const 252 FloatingObject* lastFloatFromPreviousLine() const
254 { 253 {
255 return containsFloats() ? m_floatingObjects->set().last().get() : nullpt r; 254 return containsFloats() ? m_floatingObjects->set().last().get() : nullpt r;
256 } 255 }
257 256
258 protected: 257 protected:
259 void rebuildFloatsFromIntruding(); 258 void rebuildFloatsFromIntruding();
260 void layoutInlineChildren(bool relayoutChildren, LayoutUnit& paintInvalidati onLogicalTop, LayoutUnit& paintInvalidationLogicalBottom, LayoutUnit afterEdge); 259 void layoutInlineChildren(bool relayoutChildren, LayoutUnit& paintInvalidati onLogicalTop, LayoutUnit& paintInvalidationLogicalBottom, LayoutUnit afterEdge);
261 void addLowestFloatFromChildren(LayoutBlockFlow*); 260 void addLowestFloatFromChildren(LayoutBlockFlow*);
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
544 543
545 // END METHODS DEFINED IN LayoutBlockFlowLine 544 // END METHODS DEFINED IN LayoutBlockFlowLine
546 545
547 }; 546 };
548 547
549 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlockFlow, isLayoutBlockFlow()); 548 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlockFlow, isLayoutBlockFlow());
550 549
551 } // namespace blink 550 } // namespace blink
552 551
553 #endif // LayoutBlockFlow_h 552 #endif // LayoutBlockFlow_h
OLDNEW
« no previous file with comments | « Source/core/layout/FloatingObjects.cpp ('k') | Source/core/layout/LayoutBlockFlow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698