C API: add radial, sweep, and two-point conical gradient shaders

C API: add radial, sweep, and two-point conical gradient shaders

Committed: https://skia.googlesource.com/skia/+/65cc3e46445a26aadd21f111e0d69fd18fd8aa11

[hal.canary, 2015-07-31 22:11:36]

halcanary@google.com changed reviewers:
+ reed@google.com

[hal.canary, 2015-07-31 22:11:37]

PTAL

[reed1, 2015-08-03 14:06:28]

lets just expose the gradients for now.

[hal.canary, 2015-08-03 14:35:58]

On 2015/08/03 14:06:28, reed1 wrote:
> lets just expose the gradients for now.

Done

[reed1, 2015-08-03 14:52:58]

https://codereview.chromium.org/1263773006/diff/20001/include/c/sk_shader.h
File include/c/sk_shader.h (right):

https://codereview.chromium.org/1263773006/diff/20001/include/c/sk_shader.h#n...
include/c/sk_shader.h:74: sk_shader_t* sk_shader_new_radial_gradient(sk_point_t
center,
It this std/stable convention in C, to pass a struct by value? I had thought for
C we should pass 

const sk_point_t*

[hal.canary, 2015-08-03 15:07:15]

On 2015/08/03 14:52:58, reed1 wrote:
> https://codereview.chromium.org/1263773006/diff/20001/include/c/sk_shader.h
> File include/c/sk_shader.h (right):
> 
>
https://codereview.chromium.org/1263773006/diff/20001/include/c/sk_shader.h#n...
> include/c/sk_shader.h:74: sk_shader_t*
sk_shader_new_radial_gradient(sk_point_t
> center,
> It this std/stable convention in C, to pass a struct by value? I had thought
for
> C we should pass 
> 
> const sk_point_t*

Done

[hal.canary, 2015-08-12 14:27:29]

On 2015/08/03 15:07:15, Hal Canary wrote:
> On 2015/08/03 14:52:58, reed1 wrote:
> > https://codereview.chromium.org/1263773006/diff/20001/include/c/sk_shader.h
> > File include/c/sk_shader.h (right):
> > 
> >
https://codereview.chromium.org/1263773006/diff/20001/include/c/sk_shader.h#n...
> > include/c/sk_shader.h:74:
> >     sk_shader_t* sk_shader_new_radial_gradient(sk_point_t center,
> > It this std/stable convention in C, to pass a struct by value? I had thought
> > for C we should pass 
> > 
> > const sk_point_t*
> 
> Done

Ping.

[reed1, 2015-08-12 14:30:11]

lgtm

[hal.canary, 2015-08-12 14:30:25]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-08-12 14:30:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1263773006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1263773006/40001

[commit-bot: I haz the power, 2015-08-12 14:37:37]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/65cc3e46445a26aadd21f111e0d69fd18fd8aa11