chrome/android/java/res/layout/custom_tabs_toolbar.xml - Issue 1263583003: Let client app customize close button

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/custom_tabs_toolbar.xml

Issue 1263583003: Let client app customize close button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/btn_chevron_left.png ('k') | chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <org.chromium.chrome.browser.toolbar.CustomTabToolbar	6 <org.chromium.chrome.browser.toolbar.CustomTabToolbar

7 xmlns:android="http://schemas.android.com/apk/res/android"	7 xmlns:android="http://schemas.android.com/apk/res/android"

8 xmlns:chrome="http://schemas.android.com/apk/res-auto" >	8 xmlns:chrome="http://schemas.android.com/apk/res-auto" >

9 <org.chromium.chrome.browser.widget.TintedImageButton	9 <ImageButton

10 android:id="@+id/close_button"	10 android:id="@+id/close_button"

11 style="@style/ToolbarButton"	11 style="@style/ToolbarButton"

12 android:layout_gravity="start\|center_vertical"	12 android:layout_gravity="start\|center_vertical"

13 android:contentDescription="@string/close_tab" />	13 android:contentDescription="@string/close_tab" />

14 <FrameLayout	14 <FrameLayout

15 android:id="@+id/location_bar_frame_layout"	15 android:id="@+id/location_bar_frame_layout"

16 android:layout_width="match_parent"	16 android:layout_width="match_parent"

17 android:layout_height="wrap_content"	17 android:layout_height="wrap_content"

18 android:layout_gravity="center_vertical" >	18 android:layout_gravity="center_vertical" >

19 <ImageButton	19 <ImageButton

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
78 android:src="@drawable/btn_menu"	78 android:src="@drawable/btn_menu"

79 android:contentDescription="@string/accessibility_toolbar_btn_menu"	79 android:contentDescription="@string/accessibility_toolbar_btn_menu"

80 android:background="@null" />	80 android:background="@null" />

81 <org.chromium.chrome.browser.widget.ToolbarProgressBar	81 <org.chromium.chrome.browser.widget.ToolbarProgressBar

82 android:id="@+id/progress"	82 android:id="@+id/progress"

83 android:layout_width="match_parent"	83 android:layout_width="match_parent"

84 android:layout_height="2dp"	84 android:layout_height="2dp"

85 chrome:progressBarColor="@color/progress_bar_foreground"	85 chrome:progressBarColor="@color/progress_bar_foreground"

86 chrome:backgroundColor="@color/progress_bar_background" />	86 chrome:backgroundColor="@color/progress_bar_background" />

87 </org.chromium.chrome.browser.toolbar.CustomTabToolbar>	87 </org.chromium.chrome.browser.toolbar.CustomTabToolbar>

OLD	NEW