Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp - Issue 1263043003: Add NotificationAction.action member

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

Issue 1263043003: Add NotificationAction.action member (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@actions

Patch Set: Fix rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/notifications/NotificationAction.idl ('k') | public/platform/modules/notifications/WebNotificationAction.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

diff --git a/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp b/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

index ac2bcaec02037e1256b58a055222926dcb0ac25a..a30a13ebdce6b5aa0bb1b42ec950a78bb1e3af6a 100644

--- a/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

+++ b/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

@@ -74,8 +74,10 @@ ScriptPromise ServiceWorkerRegistrationNotifications::showNotification(ScriptSta

}

for (const NotificationAction& action : options.actions()) {

+ if (action.action().isEmpty())

+ return ScriptPromise::reject(scriptState, V8ThrowException::createTypeError(scriptState->isolate(), "NotificationAction action must not be empty."));

if (action.title().isEmpty())

- return ScriptPromise::reject(scriptState, V8ThrowException::createTypeError(scriptState->isolate(), "Notification action titles must not be empty."));

+ return ScriptPromise::reject(scriptState, V8ThrowException::createTypeError(scriptState->isolate(), "NotificationAction title must not be empty."));

}

RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);