Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Issue 12629006: Prepare for removing WebTransformationMatrix from animation APIs (Closed)

Created:
7 years, 9 months ago by jamesr
Modified:
7 years, 9 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org, Ian Vollick, shawnsingh
Visibility:
Public.

Description

Prepare for removing WebTransformationMatrix from animation APIs These APIs need to pass a 4x4 double matrix through the WebKit API. SkMatrix44 is fine for this. The additional API on WTM isn't used anywhere. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186902

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Messages

Total messages: 6 (0 generated)
jamesr
enne - please review vollick - FYI https://codereview.chromium.org/12629006/diff/7001/webkit/compositor_bindings/web_transform_animation_curve_impl.cc File webkit/compositor_bindings/web_transform_animation_curve_impl.cc (right): https://codereview.chromium.org/12629006/diff/7001/webkit/compositor_bindings/web_transform_animation_curve_impl.cc#newcode56 webkit/compositor_bindings/web_transform_animation_curve_impl.cc:56: return WebTransformationMatrix(); ...
7 years, 9 months ago (2013-03-07 23:33:15 UTC) #1
enne (OOO)
lgtm
7 years, 9 months ago (2013-03-07 23:48:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/12629006/7001
7 years, 9 months ago (2013-03-08 00:32:10 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=17574
7 years, 9 months ago (2013-03-08 04:34:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/12629006/7001
7 years, 9 months ago (2013-03-08 04:37:24 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-08 06:02:30 UTC) #6
Message was sent while issue was closed.
Change committed as 186902

Powered by Google App Engine
This is Rietveld 408576698