base/trace_event/memory_dump_manager.cc - Issue 1262333005: [tracing] Introduce MemoryDumpArgs to enable light and heavy dumps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/memory_dump_manager.cc

Issue 1262333005: [tracing] Introduce MemoryDumpArgs to enable light and heavy dumps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Win and android fix. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/trace_event/memory_allocator_dump_unittest.cc ('K') | « base/trace_event/memory_allocator_dump_unittest.cc ('k') | base/trace_event/memory_dump_manager_unittest.cc » ('j') | base/trace_event/memory_dump_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/trace_event/memory_dump_manager.cc

diff --git a/base/trace_event/memory_dump_manager.cc b/base/trace_event/memory_dump_manager.cc

index d076dda05054ce70e2f5e009c7103d68ea03c6db..3b903c34e0e9518579925f4e16dc90a846c96a2c 100644

--- a/base/trace_event/memory_dump_manager.cc

+++ b/base/trace_event/memory_dump_manager.cc

@@ -311,8 +311,14 @@ void MemoryDumpManager::ContinueAsyncProcessDump(

// Invoke the dump provider without holding the |lock_|.

bool finalize = false;

bool dump_successful = false;

+ // TODO(ssid): Change RequestGlobalDump to use MemoryDumpArgs along with

+ // MemoryDumpType to get request for light / heavy dump, and remove this

+ // constant.

+ const MemoryDumpArgs dump_args(MemoryDumpArgs::LEVEL_OF_DETAIL_HIGH);

petrcermak 2015/07/31 13:23:01 No need to build the object outside the if-stateme

ssid 2015/07/31 15:14:33 Done.

if (!skip_dump)

- dump_successful = mdp->OnMemoryDump(&pmd_async_state->process_memory_dump);

+ dump_successful =

+ mdp->OnMemoryDump(dump_args, &pmd_async_state->process_memory_dump);

{

AutoLock lock(lock_);