[tracing] Introduce MemoryDumpArgs to enable light and heavy dumps

base/trace_event/memory_dump_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/trace_event/memory_dump_manager.h"
 
 #include <algorithm>
 
 #include "base/atomic_sequence_num.h"
 #include "base/command_line.h"
@@ skipping 293 matching lines @@
       // The thread is gone. At this point the best thing we can do is to
       // disable the dump provider and abort this dump.
       mdp_info->disabled = true;
       return AbortDumpLocked(callback, callback_task_runner, dump_guid);
     }
   }  // AutoLock(lock_)
 
   // Invoke the dump provider without holding the |lock_|.
   bool finalize = false;
   bool dump_successful = false;
+
+  // TODO(ssid): Change RequestGlobalDump to use MemoryDumpArgs along with
+  // MemoryDumpType to get request for light / heavy dump, and remove this
+  // constant.
+  const MemoryDumpArgs dump_args(MemoryDumpArgs::LEVEL_OF_DETAIL_HIGH);

[petrcermak, 2015/07/31 13:23:01]

No need to build the object outside the if-statement.

[ssid, 2015/07/31 15:14:33]

Done.

   if (!skip_dump)
-    dump_successful = mdp->OnMemoryDump(&pmd_async_state->process_memory_dump);
+    dump_successful =
+        mdp->OnMemoryDump(dump_args, &pmd_async_state->process_memory_dump);
 
   {
     AutoLock lock(lock_);
     if (did_unregister_dump_provider_) {
       return AbortDumpLocked(pmd_async_state->callback,
                              pmd_async_state->task_runner,
                              pmd_async_state->req_args.dump_guid);
     }
     auto* mdp_info = &*pmd_async_state->next_dump_provider;
     if (dump_successful) {
@@ skipping 149 matching lines @@
       next_dump_provider(next_dump_provider),
       callback(callback),
       task_runner(MessageLoop::current()->task_runner()) {
 }
 
 MemoryDumpManager::ProcessMemoryDumpAsyncState::~ProcessMemoryDumpAsyncState() {
 }
 
 }  // namespace trace_event
 }  // namespace base