Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1767)

Unified Diff: base/trace_event/memory_allocator_dump_unittest.cc

Issue 1262333005: [tracing] Introduce MemoryDumpArgs to enable light and heavy dumps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Win and android fix. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/memory_allocator_dump_unittest.cc
diff --git a/base/trace_event/memory_allocator_dump_unittest.cc b/base/trace_event/memory_allocator_dump_unittest.cc
index 85b98d65511ed556bbdb27679c65038c497a5266..d147b7d800d7be4b5fc492cc49d66c28a0e45006 100644
--- a/base/trace_event/memory_allocator_dump_unittest.cc
+++ b/base/trace_event/memory_allocator_dump_unittest.cc
@@ -21,7 +21,7 @@ namespace {
class FakeMemoryAllocatorDumpProvider : public MemoryDumpProvider {
public:
- bool OnMemoryDump(ProcessMemoryDump* pmd) override {
+ bool OnMemoryDump(const MemoryDumpArgs&, ProcessMemoryDump* pmd) override {
petrcermak 2015/07/31 13:23:01 nit: missing argument name (I know it's not strict
ssid 2015/07/31 15:14:33 Done.
MemoryAllocatorDump* root_heap =
pmd->CreateAllocatorDump("foobar_allocator");
@@ -126,7 +126,8 @@ TEST(MemoryAllocatorDumpTest, DumpIntoProcessMemoryDump) {
FakeMemoryAllocatorDumpProvider fmadp;
ProcessMemoryDump pmd(make_scoped_refptr(new MemoryDumpSessionState()));
- fmadp.OnMemoryDump(&pmd);
+ fmadp.OnMemoryDump(MemoryDumpArgs(MemoryDumpArgs::LEVEL_OF_DETAIL_HIGH),
+ &pmd);
ASSERT_EQ(3u, pmd.allocator_dumps().size());

Powered by Google App Engine
This is Rietveld 408576698