Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1261763004: Remove handling code for android_command in pylib. (Closed)

Created:
5 years, 4 months ago by nednguyen
Modified:
5 years, 4 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove handling code for android_command in pylib. BUG=267773 Committed: https://crrev.com/98a9b9019a0135f3d86f3c28aadd0295f633510f Cr-Commit-Position: refs/heads/master@{#340737}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove left over TODO comment #

Total comments: 4

Patch Set 3 : Remove 2 more TODO comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M build/android/pylib/flag_changer.py View 2 chunks +0 lines, -3 lines 0 comments Download
M build/android/pylib/forwarder.py View 1 2 4 chunks +0 lines, -8 lines 0 comments Download
M build/android/pylib/perf/cache_control.py View 1 chunk +0 lines, -3 lines 0 comments Download
M build/android/pylib/perf/perf_control.py View 2 chunks +0 lines, -3 lines 0 comments Download
M build/android/pylib/perf/surface_stats_collector.py View 2 chunks +0 lines, -3 lines 0 comments Download
M build/android/pylib/perf/thermal_throttle.py View 2 chunks +0 lines, -3 lines 0 comments Download
M build/android/pylib/screenshot.py View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
nednguyen
5 years, 4 months ago (2015-07-28 17:29:51 UTC) #2
jbudorick
lgtm w/ nit https://codereview.chromium.org/1261763004/diff/1/build/android/pylib/forwarder.py File build/android/pylib/forwarder.py (right): https://codereview.chromium.org/1261763004/diff/1/build/android/pylib/forwarder.py#newcode74 build/android/pylib/forwarder.py:74: # TODO(jbudorick) Remove once telemetry gets ...
5 years, 4 months ago (2015-07-28 17:31:42 UTC) #3
nednguyen
https://codereview.chromium.org/1261763004/diff/1/build/android/pylib/forwarder.py File build/android/pylib/forwarder.py (right): https://codereview.chromium.org/1261763004/diff/1/build/android/pylib/forwarder.py#newcode74 build/android/pylib/forwarder.py:74: # TODO(jbudorick) Remove once telemetry gets switched over. On ...
5 years, 4 months ago (2015-07-28 17:39:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261763004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261763004/20001
5 years, 4 months ago (2015-07-28 17:40:01 UTC) #7
jbudorick
two more. https://codereview.chromium.org/1261763004/diff/20001/build/android/pylib/forwarder.py File build/android/pylib/forwarder.py (right): https://codereview.chromium.org/1261763004/diff/20001/build/android/pylib/forwarder.py#newcode121 build/android/pylib/forwarder.py:121: # TODO(jbudorick) Remove once telemetry gets switched ...
5 years, 4 months ago (2015-07-28 17:40:59 UTC) #8
nednguyen
Oops, silly me :P https://codereview.chromium.org/1261763004/diff/20001/build/android/pylib/forwarder.py File build/android/pylib/forwarder.py (right): https://codereview.chromium.org/1261763004/diff/20001/build/android/pylib/forwarder.py#newcode121 build/android/pylib/forwarder.py:121: # TODO(jbudorick) Remove once telemetry ...
5 years, 4 months ago (2015-07-28 17:42:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261763004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261763004/40001
5 years, 4 months ago (2015-07-28 17:43:44 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-07-28 18:53:58 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 18:54:36 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/98a9b9019a0135f3d86f3c28aadd0295f633510f
Cr-Commit-Position: refs/heads/master@{#340737}

Powered by Google App Engine
This is Rietveld 408576698