build/android/pylib/perf/perf_control.py - Issue 1261763004: Remove handling code for android_command in pylib.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/perf/perf_control.py

Issue 1261763004: Remove handling code for android_command in pylib. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove 2 more TODO comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/perf/perf_control.py

diff --git a/build/android/pylib/perf/perf_control.py b/build/android/pylib/perf/perf_control.py

index b6bf9143d247bed3f4268b7307cf69360af65e28..f7e9b518af32d31dea13e63f095d0edd9bdf659b 100644

--- a/build/android/pylib/perf/perf_control.py

+++ b/build/android/pylib/perf/perf_control.py

@@ -5,7 +5,6 @@

import atexit

import logging

-from pylib import android_commands

from pylib.device import device_errors

from pylib.device import device_utils

@@ -16,8 +15,6 @@ class PerfControl(object):

_KERNEL_MAX = '/sys/devices/system/cpu/kernel_max'

def __init__(self, device):

- # TODO(jbudorick) Remove once telemetry gets switched over.

- assert not isinstance(device, android_commands.AndroidCommands)

self._device = device

# this will raise an AdbCommandFailedError if no CPU files are found

self._cpu_files = self._device.RunShellCommand(