Remove handling code for android_command in pylib.

build/android/pylib/forwarder.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # pylint: disable=W0212
 
 import fcntl
 import logging
 import os
 import psutil
 
 from pylib import cmd_helper
 from pylib import constants
 from pylib import valgrind_tools
 
-# TODO(jbudorick) Remove once telemetry gets switched over.
-import pylib.android_commands
 import pylib.device.device_utils
 
 
 def _GetProcessStartTime(pid):
   return psutil.Process(pid).create_time
 
 
 class _FileLock(object):
   """With statement-aware implementation of a file lock.
 
@@ skipping 38 matching lines @@
                  port will by dynamically assigned on the device. You can
                  get the number of the assigned port using the
                  DevicePortForHostPort method.
       device: A DeviceUtils instance.
       tool: Tool class to use to get wrapper, if necessary, for executing the
             forwarder (see valgrind_tools.py).
 
     Raises:
       Exception on failure to forward the port.
     """
     # TODO(jbudorick) Remove once telemetry gets switched over.

[jbudorick, 2015/07/28 17:31:42]

these can go too :P

[nednguyen, 2015/07/28 17:39:38]

Done.

-    assert not isinstance(device, pylib.android_commands.AndroidCommands)
     if not tool:
       tool = valgrind_tools.CreateTool(None, device)
     with _FileLock(Forwarder._LOCK_PATH):
       instance = Forwarder._GetInstanceLocked(tool)
       instance._InitDeviceLocked(device, tool)
 
       device_serial = str(device)
       redirection_commands = [
           ['--adb=' + constants.GetAdbPath(),
            '--serial-id=' + device_serial,
@@ skipping 28 matching lines @@
 
   @staticmethod
   def UnmapDevicePort(device_port, device):
     """Unmaps a previously forwarded device port.
 
     Args:
       device: A DeviceUtils instance.
       device_port: A previously forwarded port (through Map()).
     """
     # TODO(jbudorick) Remove once telemetry gets switched over.
-    assert not isinstance(device, pylib.android_commands.AndroidCommands)
     with _FileLock(Forwarder._LOCK_PATH):
       Forwarder._UnmapDevicePortLocked(device_port, device)
 
   @staticmethod
   def UnmapAllDevicePorts(device):
     """Unmaps all the previously forwarded ports for the provided device.
 
     Args:
       device: A DeviceUtils instance.
       port_pairs: A list of tuples (device_port, host_port) to unmap.
     """
     # TODO(jbudorick) Remove once telemetry gets switched over.
-    assert not isinstance(device, pylib.android_commands.AndroidCommands)
     with _FileLock(Forwarder._LOCK_PATH):
       if not Forwarder._instance:
         return
       adb_serial = str(device)
       if adb_serial not in Forwarder._instance._initialized_devices:
         return
       port_map = Forwarder._GetInstanceLocked(
           None)._device_to_host_port_map
       for (device_serial, device_port) in port_map.keys():
         if adb_serial == device_serial:
@@ skipping 169 matching lines @@
     logging.info('Killing device_forwarder.')
     Forwarder._instance._initialized_devices.discard(str(device))
     if not device.FileExists(Forwarder._DEVICE_FORWARDER_PATH):
       return
 
     cmd = '%s %s --kill-server' % (tool.GetUtilWrapper(),
                                    Forwarder._DEVICE_FORWARDER_PATH)
     device.RunShellCommand(
         cmd, env={'LD_LIBRARY_PATH': Forwarder._DEVICE_FORWARDER_FOLDER},
         check_return=True)