Issue 1261273003: relnote: Change the QuicStreamSequencer to call OnDataAvailable instead

Issue 1261273003: relnote: Change the QuicStreamSequencer to call OnDataAvailable instead (Closed)

Created:
5 years, 4 months ago by ramant (doing other things)

Modified:
5 years, 4 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

relnote: Change the QuicStreamSequencer to call OnDataAvailable instead of OnFinRead when the fin is consumed. Make ReliableQuicStream::OnFinRead() non-virtual and remove overrides in subclasses. Merge internal change: 99214926 R=rch@chromium.org

Patch Set 1 #

Total comments: 2

Patch Set 2 : Replace DonReading with OnFinRead #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -28 lines)			Patch
M	net/quic/quic_http_stream.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_reliable_client_stream.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/quic/quic_reliable_client_stream.cc	View	1	2 chunks	+1 line, -10 lines	0 comments	Download
M	net/quic/quic_stream_sequencer.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	net/quic/quic_stream_sequencer_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/reliable_quic_stream.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	net/tools/quic/quic_spdy_server_stream.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	net/tools/quic/quic_spdy_server_stream.cc	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Depends on Patchset:

Issue 1244073002 Patch 1

Dependent Patchsets:

Issue 1274003002 Patch 1

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

https://codereview.chromium.org/1261273003/diff/1/net/quic/quic_reliable_client_stream.cc File net/quic/quic_reliable_client_stream.cc (left): https://codereview.chromium.org/1261273003/diff/1/net/quic/quic_reliable_client_stream.cc#oldcode85 net/quic/quic_reliable_client_stream.cc:85: void QuicReliableClientStream::DoneReading() { Might as well get right of ...

5 years, 4 months ago (2015-08-04 20:28:56 UTC) #2

ramant (doing other things)

Thanks Ryan (made the changes). PTAL. https://codereview.chromium.org/1261273003/diff/1/net/quic/quic_reliable_client_stream.cc File net/quic/quic_reliable_client_stream.cc (left): https://codereview.chromium.org/1261273003/diff/1/net/quic/quic_reliable_client_stream.cc#oldcode85 net/quic/quic_reliable_client_stream.cc:85: void QuicReliableClientStream::DoneReading() { ...

5 years, 4 months ago (2015-08-05 23:35:16 UTC) #3

lgtm

Expand Messages | Collapse Messages